Replies: 2 comments 6 replies
-
|
I think since the recent move to using Timers.xml instead of Alarms has changed the way Fuse deals with how autoplay trailers work. It has introduced some great efficiency/navigation gains across the skin but also changed a few things (like autoplaying trailers instead of autoscrolling when the main menu is highlighted). I am not exactly sure if Jurial meant this one as an intentional change. Along with my comment here (for a different bug), changing these lines and prefixing them with and then adjusting this line and changing it to should accomodate (hopefully) your previous use case whilst not breaking anything with the current version of the skin. As mentioned in my previous comment, these are all speculative guesses so I'd suggest waiting for Jurial's official answer just to be safe. |
Beta Was this translation helpful? Give feedback.
-
|
@OfficerKD637 - I'll respond here instead of the other issue thread to avoid derailing it too much.
The playing trailers whilst the menu is focused is intentional. The idea is that trailers should autoplay if the spotlight is the current widget in view regardless of what control you have focused. So there's no need to add the This behaviour previously did not occur because the old method simply did not allow for it, but it was always my intention to implement it once I switched to Timers
This condition is broken because you have an unenclosed OR condition mixed with AND conditions-- it "works" to allow autoscroll because the condition is invalidating all the parts after
This is meaningless. It does nothing and the condition will never be TRUE because OnNext is only ever TRUE for a few ms (when you first trigger a scroll).
This is literally undoing a fix I just implemented to avoid trailers restarting unnecessarily after they finish playing. Otherwise trailers replay on an endless loop. Trailers also should not start after being stopped due to context menu opening etc. as otherwise the trailer playback will override actions in the contextmenu (e.g. like if you chose "Play" on a movie, then the trailer will start up afterwards and play instead of the movie because the contextmenu closed and there was a brief moment when the spotlight had focus again!!!!). |
Beta Was this translation helpful? Give feedback.
-
|
Yiiikes. I made a big fool out of myself. Can't believe there were so many fundamental errors. I thought the code "worked" so it must be right lol. Now I'm extremely embarrassed and I should probably delete these before the other members see the posts haha. But thank you for taking the time to explain everything to me. Maybe I can be less stupid next time. |
Beta Was this translation helpful? Give feedback.
-
Don't worry, I do this all the time! It's the only reason I'm good at spotting it. Was looking at the condition thinking it shouldn't do what you expect it to do, so my immediate thought was must be missing a bracket somewhere and, yep, it was.
The rest is reasonable, especially the restart trailer code - because that's exactly what I had before. You can see in this commit where I removed pretty much exactly that code and the issue it references for why it was removed: 01494a5 The reason for never clearing the PlayTrailer value is because we want to know what the last trailer was that played so that we don't keep starting it on a loop. Wanting to resume it again is totally reasonable - you can see that discussion pretty much exactly play out in the thread linked to that commit. And I see what you're trying to do with the Container.OnNext - it just doesn't work how you think it does, not only because it is practically impossible for the condition to be true, but also because |
Beta Was this translation helpful? Give feedback.
-
|
@tapwiz - I think this should solve the autoscroll behaviour 78e995c Essentially it should autoscroll if all the following conditions are met:
|
Beta Was this translation helpful? Give feedback.
-
|
Wowww! This is what I was trying to pull off and you did it so efficiently. Literally perfect! |
Beta Was this translation helpful? Give feedback.
-
|
I just checked. The spotlight auto-scroll now works when the trailer has finished. Much appreciated, but I didn't mean for you to go out of your way to change the way your skin works. |
Beta Was this translation helpful? Give feedback.
-
|
No it was no trouble! It was definitely a bug and not intentional that it didn't scroll at all, so I wanted to make sure to fix it. |
Beta Was this translation helpful? Give feedback.
-
In the last couple of releases the automatic trailer (spotlight) plays while on the main menu (top bar). This plays the trailer for the first item in (spotlight) widget selected. Then it just stays on that item unless you move down and press one of the arrows to advance, there is no more auto-scroll for spotlight unless you disable play trailers automatically (spotlight). Previously, while on main menus the spotlight selected would auto-scroll and the trailer would play automatically if you moved down to the info area. I'm just wondering if this is correct and the new way the skin is supposed to work, or is my build messed up somehow. Thanks.
Beta Was this translation helpful? Give feedback.
All reactions