Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Titles in Spotlight are jumping around #963

Closed
4 tasks done
Rinicko100 opened this issue Jun 19, 2024 · 7 comments
Closed
4 tasks done

馃悰 Titles in Spotlight are jumping around #963

Rinicko100 opened this issue Jun 19, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@Rinicko100
Copy link

Skin section

Widgets

Current Behavior

Hello... I've noticed an issue with the titles on spotlight widget after recent change in title label approach... The titles seem to jump around from one size to another which makes it look a bit rough.

The video below is low quality but it does show the title jumping

Kodi_20240619_120743_Manual.mp4

Also, it is not due to the change of font as I also tried it with the default font and got same result

Expected Behavior

Titles should display normally

Steps To Reproduce

Create a spotlight widget
Navigate from one item to the other

Screenshots and Additional Info

No response

Checklist

  • I have made a separate issue for each bug that I am reporting.
  • I have searched the issues and this bug has not been reported.
  • I am using the most recent skin version.
  • I have confirmed that this bug does not occur in the default skin.
@Rinicko100 Rinicko100 added the bug Something isn't working label Jun 19, 2024
@jurialmunkey
Copy link
Owner

Back to people whinging about the Kodi logo instead I guess it is then!

@jurialmunkey
Copy link
Owner

jurialmunkey commented Jun 20, 2024

I'm a little confused though, If you don't mind explaining it to me馃馃... OfficerKD spotted a way to remove the kodi logo... and it didn't seem to affect anything

Not affecting function and not affecting visual balance are two separate things.

The issue is that the title font is significantly smaller than most clearlogos. This size difference creates visual balance issues with vertical space.

Vertically centering the title in the space creates a large disconnecting gap to the info/plot. Bottom aligning the title creates an imbalance in the padding to the header in standard views.

One solution is to add the "eyebrow" anchor of the Kodi logo to allow bottom alignment whilst still filling the vertical space to retain appropriate padding (e.g. similar to what Netflix series do). Another solution is having a variable sized font to switch from larger single line, to smaller double line and continue to fill the vertical space consistently.

All options have downsides:
Variable height = Laggy
Kodi logo = Extra clutter
Small font only = Visually unbalanced
Large font only = Longer titles truncated

Ultimately I decided last is best - It's the most performant option (less elements) and best suits the minimal style of the skin. If people complain about long titles not fitting then they they can turn on label scrolling.

@Rinicko100
Copy link
Author

I'm a little confused though, If you don't mind explaining it to me馃馃... OfficerKD spotted a way to remove the kodi logo... and it didn't seem to affect anything

Not affecting function and not affecting visual balance are two separate things.

The issue is that the title font is significantly smaller than most clearlogos. This size difference creates visual balance issues with vertical space.

Vertically centering the title in the space creates a large disconnecting gap to the info/plot. Bottom aligning the title creates an imbalance in the padding to the header in standard views.

One solution is to add the "eyebrow" anchor of the Kodi logo to allow bottom alignment whilst still filling the vertical space to retain appropriate padding (e.g. similar to what Netflix series do). Another solution is having a variable sized font to switch from larger single line, to smaller double line and continue to fill the vertical space consistently.

All options have downsides:
Variable height = Laggy
Kodi logo = Extra clutter
Small font only = Visually unbalanced
Large font only = Longer titles truncated

Ultimately I decided last is best - It's the most performant option (less elements) and best suits the minimal style of the skin. If people complain about long titles not fitting then they they can turn on label scrolling.

I see 馃馃... I fully understand now. Thanks for the explanation... I also think large font with scrolling labels is best.. I'd probably reduce the font size on my end, but it's still better than the kodi logo for people who don't want to tinker with font.xml or use clearlogos

@xyzfre
Copy link

xyzfre commented Jun 20, 2024

Back to people whinging about the Kodi logo instead I guess it is then!

The Kodi logo use to look perfect the way you had it ,,way better Then having the large Fonts.

@vella9
Copy link

vella9 commented Jun 20, 2024

Was it ever considered creating a logo specifically to the skin? This can replace the kodi logo without too much trouble and can also be used elsewhere in the skin maybe. Just asking.

@xyzfre
Copy link

xyzfre commented Jun 20, 2024

Was it ever considered creating a logo specifically to the skin? This can replace the kodi logo without too much trouble and can also be used elsewhere in the skin maybe. Just asking.

This also sounds like a GREAT idea ,, and the fonts can go back to the way they were before which look way better ,maybe a Arctic Fuse logo馃

@vella9
Copy link

vella9 commented Jun 20, 2024

maybe a Arctic Fuse logo

that's what I thought. It would be a nice addition I think. Let's see if jurial likes the idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants