forked from gravitational/teleport
-
Notifications
You must be signed in to change notification settings - Fork 0
/
dynamic_access.go
387 lines (358 loc) · 12.2 KB
/
dynamic_access.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
/*
* Teleport
* Copyright (C) 2023 Gravitational, Inc.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
package local
import (
"bytes"
"context"
"slices"
"time"
"github.com/gravitational/trace"
"github.com/gravitational/teleport/api/types"
"github.com/gravitational/teleport/api/utils/retryutils"
"github.com/gravitational/teleport/lib/backend"
"github.com/gravitational/teleport/lib/services"
)
// DynamicAccessService manages dynamic RBAC
type DynamicAccessService struct {
backend.Backend
}
// NewDynamicAccessService returns new dynamic access service instance
func NewDynamicAccessService(backend backend.Backend) *DynamicAccessService {
return &DynamicAccessService{Backend: backend}
}
// CreateAccessRequest stores a new access request.
func (s *DynamicAccessService) CreateAccessRequest(ctx context.Context, req types.AccessRequest) error {
_, err := s.CreateAccessRequestV2(ctx, req)
return trace.Wrap(err)
}
// CreateAccessRequestV2 stores a new access request.
func (s *DynamicAccessService) CreateAccessRequestV2(ctx context.Context, req types.AccessRequest) (types.AccessRequest, error) {
if err := services.ValidateAccessRequest(req); err != nil {
return nil, trace.Wrap(err)
}
if req.GetDryRun() {
return nil, trace.BadParameter("dry run access request made it to DynamicAccessService, this is a bug")
}
item, err := itemFromAccessRequest(req)
if err != nil {
return nil, trace.Wrap(err)
}
if _, err := s.Create(ctx, item); err != nil {
return nil, trace.Wrap(err)
}
return req, nil
}
// SetAccessRequestState updates the state of an existing access request.
func (s *DynamicAccessService) SetAccessRequestState(ctx context.Context, params types.AccessRequestUpdate) (types.AccessRequest, error) {
if err := params.Check(); err != nil {
return nil, trace.Wrap(err)
}
retry, err := retryutils.NewLinear(retryutils.LinearConfig{
Step: retryPeriod / 7,
Max: retryPeriod,
})
if err != nil {
return nil, trace.Wrap(err)
}
// Setting state is attempted multiple times in the event of concurrent writes.
// The reason we bother to re-attempt is because state updates aren't meant
// to be "first come first serve". Denials should overwrite approvals, but
// approvals should not overwrite denials.
for i := 0; i < maxCmpAttempts; i++ {
item, err := s.Get(ctx, accessRequestKey(params.RequestID))
if err != nil {
if trace.IsNotFound(err) {
return nil, trace.NotFound("cannot set state of access request %q (not found)", params.RequestID)
}
return nil, trace.Wrap(err)
}
req, err := itemToAccessRequest(*item)
if err != nil {
return nil, trace.Wrap(err)
}
if err := req.SetState(params.State); err != nil {
return nil, trace.Wrap(err)
}
req.SetResolveReason(params.Reason)
req.SetResolveAnnotations(params.Annotations)
if len(params.Roles) > 0 {
for _, role := range params.Roles {
if !slices.Contains(req.GetRoles(), role) {
return nil, trace.BadParameter("role %q not in original request, overrides must be a subset of original role list", role)
}
}
req.SetRoles(params.Roles)
}
// approved requests should have a resource expiry which matches
// the underlying access expiry.
if params.State.IsApproved() {
req.SetExpiry(req.GetAccessExpiry())
}
newItem, err := itemFromAccessRequest(req)
if err != nil {
return nil, trace.Wrap(err)
}
if _, err := s.CompareAndSwap(ctx, *item, newItem); err != nil {
if trace.IsCompareFailed(err) {
select {
case <-retry.After():
retry.Inc()
continue
case <-ctx.Done():
return nil, trace.Wrap(ctx.Err())
}
}
return nil, trace.Wrap(err)
}
return req, nil
}
return nil, trace.CompareFailed("too many concurrent writes to access request %s, try again later", params.RequestID)
}
// ApplyAccessReview applies a review to a request and returns the post-application state.
func (s *DynamicAccessService) ApplyAccessReview(ctx context.Context, params types.AccessReviewSubmission, checker services.ReviewPermissionChecker) (types.AccessRequest, error) {
if err := params.Check(); err != nil {
return nil, trace.Wrap(err)
}
retry, err := retryutils.NewLinear(retryutils.LinearConfig{
Step: retryPeriod / 7,
Max: retryPeriod,
})
if err != nil {
return nil, trace.Wrap(err)
}
// Review application is attempted multiple times in the event of concurrent writes.
for i := 0; i < maxCmpAttempts; i++ {
item, err := s.Get(ctx, accessRequestKey(params.RequestID))
if err != nil {
if trace.IsNotFound(err) {
return nil, trace.NotFound("cannot apply review to access request %q (not found)", params.RequestID)
}
return nil, trace.Wrap(err)
}
req, err := itemToAccessRequest(*item)
if err != nil {
return nil, trace.Wrap(err)
}
// verify review permissions against request details
if ok, err := checker.CanReviewRequest(req); err != nil || !ok {
if err == nil {
err = trace.AccessDenied("user %q cannot review request %q", params.Review.Author, params.RequestID)
}
return nil, trace.Wrap(err)
}
// run the application logic
if err := services.ApplyAccessReview(req, params.Review, checker.UserState); err != nil {
return nil, trace.Wrap(err)
}
newItem, err := itemFromAccessRequest(req)
if err != nil {
return nil, trace.Wrap(err)
}
if _, err := s.CompareAndSwap(ctx, *item, newItem); err != nil {
if trace.IsCompareFailed(err) {
select {
case <-retry.After():
retry.Inc()
continue
case <-ctx.Done():
return nil, trace.Wrap(ctx.Err())
}
}
return nil, trace.Wrap(err)
}
return req, nil
}
return nil, trace.CompareFailed("too many concurrent writes to access request %s, try again later", params.RequestID)
}
func (s *DynamicAccessService) GetAccessRequest(ctx context.Context, name string) (types.AccessRequest, error) {
item, err := s.Get(ctx, accessRequestKey(name))
if err != nil {
if trace.IsNotFound(err) {
return nil, trace.NotFound("access request %q not found", name)
}
return nil, trace.Wrap(err)
}
req, err := itemToAccessRequest(*item)
if err != nil {
return nil, trace.Wrap(err)
}
return req, nil
}
// GetAccessRequests gets all currently active access requests.
func (s *DynamicAccessService) GetAccessRequests(ctx context.Context, filter types.AccessRequestFilter) ([]types.AccessRequest, error) {
// Filters which specify ID are a special case since they will match exactly zero or one
// possible requests.
if filter.ID != "" {
req, err := s.GetAccessRequest(ctx, filter.ID)
if err != nil {
// A filter with zero matches is still a success, it just
// happens to return an empty slice.
if trace.IsNotFound(err) {
return nil, nil
}
return nil, trace.Wrap(err)
}
if !filter.Match(req) {
// A filter with zero matches is still a success, it just
// happens to return an empty slice.
return nil, nil
}
return []types.AccessRequest{req}, nil
}
startKey := backend.ExactKey(accessRequestsPrefix)
endKey := backend.RangeEnd(startKey)
result, err := s.GetRange(ctx, startKey, endKey, backend.NoLimit)
if err != nil {
return nil, trace.Wrap(err)
}
var requests []types.AccessRequest
for _, item := range result.Items {
if !bytes.HasSuffix(item.Key, []byte(paramsPrefix)) {
// Item represents a different resource type in the
// same namespace.
continue
}
req, err := itemToAccessRequest(item)
if err != nil {
return nil, trace.Wrap(err)
}
if !filter.Match(req) {
continue
}
requests = append(requests, req)
}
return requests, nil
}
// DeleteAccessRequest deletes an access request.
func (s *DynamicAccessService) DeleteAccessRequest(ctx context.Context, name string) error {
err := s.Delete(ctx, accessRequestKey(name))
if err != nil {
if trace.IsNotFound(err) {
return trace.NotFound("cannot delete access request %q (not found)", name)
}
return trace.Wrap(err)
}
return nil
}
func (s *DynamicAccessService) DeleteAllAccessRequests(ctx context.Context) error {
startKey := backend.ExactKey(accessRequestsPrefix)
endKey := backend.RangeEnd(startKey)
return trace.Wrap(s.DeleteRange(ctx, startKey, endKey))
}
func (s *DynamicAccessService) UpsertAccessRequest(ctx context.Context, req types.AccessRequest) error {
if err := services.ValidateAccessRequest(req); err != nil {
return trace.Wrap(err)
}
item, err := itemFromAccessRequest(req)
if err != nil {
return trace.Wrap(err)
}
if _, err := s.Put(ctx, item); err != nil {
return trace.Wrap(err)
}
return nil
}
// CreateAccessRequestAllowedPromotions creates AccessRequestAllowedPromotions object.
func (s *DynamicAccessService) CreateAccessRequestAllowedPromotions(ctx context.Context, req types.AccessRequest, accessLists *types.AccessRequestAllowedPromotions) error {
// create the new access request promotion object
item, err := itemFromAccessListPromotions(req, accessLists)
if err != nil {
return trace.Wrap(err)
}
// Currently, this logic is used only internally (no API exposed), and
// there is only one place that calls it. If this ever changes, we will
// need to do a CompareAndSwap here.
if _, err := s.Put(ctx, item); err != nil {
return trace.Wrap(err)
}
return nil
}
// GetAccessRequestAllowedPromotions returns AccessRequestAllowedPromotions object.
func (s *DynamicAccessService) GetAccessRequestAllowedPromotions(ctx context.Context, req types.AccessRequest) (*types.AccessRequestAllowedPromotions, error) {
// get the access request promotions from the backend
item, err := s.Get(ctx, AccessRequestAllowedPromotionKey(req.GetName()))
if err != nil {
if trace.IsNotFound(err) {
// do not return nil as the caller will assume that nil error
// means that there are some promotions
return types.NewAccessRequestAllowedPromotions(nil), nil
}
return nil, trace.Wrap(err)
}
// unmarshal the access request promotions
promotions, err := services.UnmarshalAccessRequestAllowedPromotion(item.Value)
if err != nil {
return nil, trace.Wrap(err)
}
return promotions, nil
}
func itemFromAccessRequest(req types.AccessRequest) (backend.Item, error) {
rev := req.GetRevision()
value, err := services.MarshalAccessRequest(req)
if err != nil {
return backend.Item{}, trace.Wrap(err)
}
return backend.Item{
Key: accessRequestKey(req.GetName()),
Value: value,
Expires: req.Expiry(),
ID: req.GetResourceID(),
Revision: rev,
}, nil
}
func itemFromAccessListPromotions(req types.AccessRequest, suggestedItems *types.AccessRequestAllowedPromotions) (backend.Item, error) {
value, err := services.MarshalAccessRequestAllowedPromotion(suggestedItems)
if err != nil {
return backend.Item{}, trace.Wrap(err)
}
return backend.Item{
Key: AccessRequestAllowedPromotionKey(req.GetName()),
Value: value,
Expires: req.Expiry(), // expire the promotion at the same time as the access request
ID: req.GetResourceID(),
Revision: req.GetRevision(),
}, nil
}
func itemToAccessRequest(item backend.Item, opts ...services.MarshalOption) (types.AccessRequest, error) {
opts = append(
opts,
services.WithResourceID(item.ID),
services.WithExpires(item.Expires),
services.WithRevision(item.Revision),
)
req, err := services.UnmarshalAccessRequest(
item.Value,
opts...,
)
if err != nil {
return nil, trace.Wrap(err)
}
return req, nil
}
func accessRequestKey(name string) []byte {
return backend.Key(accessRequestsPrefix, name, paramsPrefix)
}
func AccessRequestAllowedPromotionKey(name string) []byte {
return backend.Key(accessRequestPromotionPrefix, name, paramsPrefix)
}
const (
accessRequestsPrefix = "access_requests"
accessRequestPromotionPrefix = "access_request_promotions"
maxCmpAttempts = 7
retryPeriod = 2048 * time.Millisecond
)