Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement]:Add scoped error enum for customer error #1580

Closed
Tracked by #1579
lsampras opened this issue Jul 1, 2023 · 1 comment · Fixed by #1988
Closed
Tracked by #1579

[enhancement]:Add scoped error enum for customer error #1580

lsampras opened this issue Jul 1, 2023 · 1 comment · Fixed by #1988
Assignees
@jeevaprakashdr @lsampras
Labels
A-customers Area: Customer Flow/API's A-errors Area: error messages, structure & logging C-refactor Category: Refactor good first issue Good for newcomers help wanted Extra attention is needed

Comments

@lsampras
Copy link
Member

lsampras commented Jul 1, 2023 •
edited

tracked in #1579

We wanna use scoped errors + Errorswitch for customer API's

Currently customer API's returns the common errors enum...
It uses

CustomerRedacted
CustomerNotFound
MandateNotFound
& a lot of InternalServerError's

instead we need to figure the errors raised here & add the corresponding variants...
@lsampras lsampras added C-refactor Category: Refactor A-errors Area: error messages, structure & logging A-customers Area: Customer Flow/API's labels Jul 1, 2023
@lsampras lsampras mentioned this issue Jul 1, 2023
Open
3 tasks
@lsampras lsampras added the help wanted Extra attention is needed label Jul 2, 2023
@Chethan-rao Chethan-rao added good first issue Good for newcomers S-unassigned Status: This issue has no one assigned to address it labels Jul 5, 2023
@lsampras lsampras mentioned this issue Jul 18, 2023
Closed
@jeevaprakashdr
Copy link
Contributor

jeevaprakashdr commented Jul 27, 2023 •
edited

@lsampras @Chethan-rao please can you assign this issue to me? Also please can you update the description if there is anything changed since the issue is written

@lsampras lsampras removed the S-unassigned Status: This issue has no one assigned to address it label Jul 31, 2023
@jeevaprakashdr jeevaprakashdr mentioned this issue Aug 22, 2023
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeevaprakashdr jeevaprakashdr

@lsampras lsampras

Labels
A-customers Area: Customer Flow/API's A-errors Area: error messages, structure & logging C-refactor Category: Refactor good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(router): Add scoped error enum for customer error jeevaprakashdr/hyperswitch
4 participants
@jeevaprakashdr @lsampras @Chethan-rao @ThisIsMani