Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Implement MerchantKeyStoreInterface for MockDb #1697

Closed
2 tasks done
Tracked by #172
ThisIsMani opened this issue Jul 13, 2023 · 1 comment · Fixed by #1772
Closed
2 tasks done
Tracked by #172

[FEATURE] Implement MerchantKeyStoreInterface for MockDb #1697

ThisIsMani opened this issue Jul 13, 2023 · 1 comment · Fixed by #1772
Assignees
@SanchithHegde
Labels
A-framework Area: Framework C-feature Category: Feature request or enhancement good first issue Good for newcomers help wanted Extra attention is needed
Milestone
July 2023 Release

Comments

@ThisIsMani
Copy link
Contributor

Feature Description

Currently the MerchantKeyStoreInterface is not implemented for MockDb. It is required for merchant account functions. And without this implementation, we cannot write tests for them.

Possible Implementation

Checkout #172 for more details.

Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

Have you read the Contributing Guidelines?

Are you willing to submit a PR?

None
@ThisIsMani ThisIsMani added C-feature Category: Feature request or enhancement S-awaiting-triage Status: New issues that have not been assessed yet labels Jul 13, 2023
@ThisIsMani ThisIsMani mentioned this issue Jul 13, 2023
Open
25 tasks
@ThisIsMani ThisIsMani added A-framework Area: Framework good first issue Good for newcomers help wanted Extra attention is needed and removed S-awaiting-triage Status: New issues that have not been assessed yet labels Jul 13, 2023
@SanchithHegde SanchithHegde mentioned this issue Jul 18, 2023
Merged
12 tasks
@SanchithHegde
Copy link
Member

I'll be taking this up as this is one of the MockDb implementations that would enable us to add tests.

@SanchithHegde SanchithHegde self-assigned this Jul 18, 2023
@SanchithHegde SanchithHegde added this to the July 2023 Release milestone Jul 18, 2023
@SanchithHegde SanchithHegde mentioned this issue Jul 24, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SanchithHegde SanchithHegde

Labels
A-framework Area: Framework C-feature Category: Feature request or enhancement good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
July 2023 Release
Development

Successfully merging a pull request may close this issue.

feat(db): implement MerchantKeyStoreInterface for MockDb juspay/hyperswitch
2 participants
@SanchithHegde @ThisIsMani