Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR]: [Airwallex] Remove Default Case Handling #2262

Closed
2 tasks done
Sakilmostak opened this issue Sep 22, 2023 · 11 comments · Fixed by #2703
Closed
2 tasks done

[REFACTOR]: [Airwallex] Remove Default Case Handling #2262

Sakilmostak opened this issue Sep 22, 2023 · 11 comments · Fixed by #2703
Assignees
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement good first issue Good for newcomers hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions

Comments

@Sakilmostak
Copy link
Contributor

📝 Feature Description

  • We utilize match statements to make pivotal decisions, such as generating requests based on the payment method type and managing responses received from the connector.
  • These conditions generally go hand in hand with enum variants.
  • Default case is used because a match statement needs to be exhaustive i.e. every variant needs to be covered.
  • So, if all the explicit cases are handled then default is used to handle the rest.
  • Each connector have these match statements but many of them don’t provide reference to each variant in their default case, rather a _ is put to handle all the other cases.
  • This approach carries a risk because developers may inadvertently overlook the need for explicit handling of the new cases.

🔨 Possible Implementation

🔖 Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/

📦 Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

📦 Have you read the Contributing Guidelines?

✨ Are you willing to submit a PR?

@Sakilmostak Sakilmostak added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-awaiting-triage Status: New issues that have not been assessed yet hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Sep 22, 2023
@VedantKhairnar VedantKhairnar added the good first issue Good for newcomers label Sep 28, 2023
@Vishalk91-4
Copy link

@VedantKhairnar, could you please assign this issue to me

@Sakilmostak Sakilmostak removed the S-awaiting-triage Status: New issues that have not been assessed yet label Oct 15, 2023
@Sakilmostak
Copy link
Contributor Author

Hello @Vishalk91-4 , I have assigned this issue to you👍

@Sakilmostak
Copy link
Contributor Author

Hey @Vishalk91-4 it seems like you already have a PR in review which you have not addressed (CI checks not passed). I would suggest to be atleast done with the reviewing of the PR to move on to next

@swangi-kumari
Copy link
Contributor

Hello @Vishalk91-4 ,
Are you still working on this issue?
Please let us know if you need any help:)

@Vishalk91-4
Copy link

@swangi-kumari, yes I'm working on it, I'll submit a PR also, a draft PR if you want can be submitted too, actually I was resolving the issue of my PR in hyperswitch in other PR also

@deepanshu-iiitu
Copy link
Contributor

Hey @Vishalk91-4
Just checking in - are you working on it? Do you need help from our side?

@deepanshu-iiitu
Copy link
Contributor

Hello @Vishalk91-4 , we didn't hear back from you, so we are unassigning you from this issue. If you are interested, we will assign you with other issues, if the current one is taken.

@deepanshu-iiitu deepanshu-iiitu added the S-awaiting-triage Status: New issues that have not been assessed yet label Oct 26, 2023
@Hangsaai
Copy link
Contributor

Hey @deepanshu-iiitu ,
"Could you please assign this issue to me? My previous PR has been merged, and I want to work on it now."

@Vishalk91-4
Copy link

Hello @Vishalk91-4 , we didn't hear back from you, so we are unassigning you from this issue. If you are interested, we will assign you with other issues, if the current one is taken.

Sorry, I'm resolving errors in the other issue in Hyperswitch
#2226

@deepanshu-iiitu
Copy link
Contributor

Hey @Hangsaai , sure! I've assigned this to you.

In case you have any queries, you can ask them on this issue thread, or on our discord server, or on slack whichever you are comfortable with

@deepanshu-iiitu deepanshu-iiitu removed the S-awaiting-triage Status: New issues that have not been assessed yet label Oct 26, 2023
@swangi-kumari swangi-kumari linked a pull request Oct 27, 2023 that will close this issue
15 tasks
@swangi-kumari
Copy link
Contributor

Completed in this PR

@swangi-kumari swangi-kumari added the hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement good first issue Good for newcomers hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants