Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR]: [Helcim] Remove Default Case Handling #2271

Closed
2 tasks done
Sakilmostak opened this issue Sep 22, 2023 · 3 comments
Closed
2 tasks done

[REFACTOR]: [Helcim] Remove Default Case Handling #2271

Sakilmostak opened this issue Sep 22, 2023 · 3 comments
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement good first issue Good for newcomers

Comments

@Sakilmostak
Copy link
Contributor

📝 Feature Description

  • We utilize match statements to make pivotal decisions, such as generating requests based on the payment method type and managing responses received from the connector.
  • These conditions generally go hand in hand with enum variants.
  • Default case is used because a match statement needs to be exhaustive i.e. every variant needs to be covered.
  • So, if all the explicit cases are handled then default is used to handle the rest.
  • Each connector have these match statements but many of them don’t provide reference to each variant in their default case, rather a _ is put to handle all the other cases.
  • This approach carries a risk because developers may inadvertently overlook the need for explicit handling of the new cases.

🔨 Possible Implementation

🔖 Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/

📦 Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

📦 Have you read the Contributing Guidelines?

✨ Are you willing to submit a PR?

@Sakilmostak Sakilmostak added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-awaiting-triage Status: New issues that have not been assessed yet hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Sep 22, 2023
@VedantKhairnar VedantKhairnar added the good first issue Good for newcomers label Sep 28, 2023
@Abhiramjampani
Copy link

@AkshayaFoiger @Sakilmostak @VedantKhairnar
I would be delighted to work on this issue
so kindly assign me this issue
Thank You : )

@AkshayaFoiger
Copy link
Contributor

Hey @Abhiramjampani , I see that you're already assigned to #2346. For now, we'll leave this issue open to any other interested contributors. You may pick this up once your work on #2346 is completed, and if no other contributors have expressed interest on this. I hope that's fine by you

@Sakilmostak
Copy link
Contributor Author

Closed this issue since the required flow is not implemented

@Sakilmostak Sakilmostak removed S-awaiting-triage Status: New issues that have not been assessed yet hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants