[REFACTOR]: [Tsys] Remove Default Case Handling

[Sakilmostak]

📝 Feature Description

• We utilize match statements to make pivotal decisions, such as generating requests based on the payment method type and managing responses received from the connector.
• These conditions generally go hand in hand with enum variants.
• Default case is used because a match statement needs to be exhaustive i.e. every variant needs to be covered.
• So, if all the explicit cases are handled then default is used to handle the rest.
• Each connector have these match statements but many of them don’t provide reference to each variant in their default case, rather a _ is put to handle all the other cases.
• This approach carries a risk because developers may inadvertently overlook the need for explicit handling of the new cases.

🔨 Possible Implementation

• Instead of relying on a default match case _, developers should handle each and every variant explicitly.
• By doing so, if there are any changes in the future, they can readily assess the impact of their modifications simply by compiling the code.
• You can check this PR for further reference refactor(connector): [Zen] refactor Zen payment methods not implemented errors #1955

🔖 Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/

📦 Have you spent some time checking if this feature request has been raised before?

• I checked and didn't find a similar issue

📦 Have you read the Contributing Guidelines?

• I have read the Contributing Guidelines

✨ Are you willing to submit a PR?

[Harshpal007]

I would like to contribute on this request.

[AkshayaFoiger]

Hey @Harshpal007, sure! I've assigned this to you.

In case you have any queries, you can ask them on this issue thread, or on our discord server, or on slack whichever you are comfortable with

[VedantKhairnar]

Hey @Harshpal007 ,
Let us know if you face any issues. Happy to help! : )

[Harshpal007]

Hey @Harshpal007 ,
Let us know if you face any issues. Happy to help! : )

Hey thanks for reaching out,
I have understood the problem and know what to do,but facing an issue with where I should implement the solution as there are multiple paying methods.Should I implement the changes individually in the methods or should I try finding a unified solution.

[AkshayaFoiger]

Hi @Harshpal007, you have to implement the necessary modifications wherever the match arm contains a "_" value in the following file hyperswitch_oss/crates/router/src/connector/tsys/transformers.rs
Thankyou.

[VedantKhairnar]

Hey @Harshpal007 ,
Just checking in - are you working on it?
Let us know if you need any help.

[Rutam21]

@VedantKhairnar I would like to take this issue as there's been no activity on this for a while now. Also, please point out where I can refer to find the list of all the cases to be handled. Thanks.

[VedantKhairnar]

@Rutam21 At this moment, 2 issues are assigned to you. Once either of them is merged, will assign this one to you. Works?

[Rutam21]

Yeah, that works. One of the PRs is already raised and approved. Waiting for another approval before merge.

[Harshwardhan9431]

@VedantKhairnar Can you assign this issue to me.

[SanchithHegde]

Sure @Harshwardhan9431!

Edit: Un-assigning @Harshpal007 due to inactivity.