Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR]: [Worldpay] Remove Default Case Handling #2290

Closed
2 tasks done
Sakilmostak opened this issue Sep 22, 2023 · 6 comments · Fixed by #2488
Closed
2 tasks done

[REFACTOR]: [Worldpay] Remove Default Case Handling #2290

Sakilmostak opened this issue Sep 22, 2023 · 6 comments · Fixed by #2488
Assignees
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement good first issue Good for newcomers hacktoberfest Issues that are up for grabs for Hacktoberfest participants

Comments

@Sakilmostak
Copy link
Contributor

📝 Feature Description

  • We utilize match statements to make pivotal decisions, such as generating requests based on the payment method type and managing responses received from the connector.
  • These conditions generally go hand in hand with enum variants.
  • Default case is used because a match statement needs to be exhaustive i.e. every variant needs to be covered.
  • So, if all the explicit cases are handled then default is used to handle the rest.
  • Each connector have these match statements but many of them don’t provide reference to each variant in their default case, rather a _ is put to handle all the other cases.
  • This approach carries a risk because developers may inadvertently overlook the need for explicit handling of the new cases.

🔨 Possible Implementation

🔖 Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/

📦 Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

📦 Have you read the Contributing Guidelines?

✨ Are you willing to submit a PR?

@Sakilmostak Sakilmostak added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-awaiting-triage Status: New issues that have not been assessed yet hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Sep 22, 2023
@VedantKhairnar VedantKhairnar added the good first issue Good for newcomers label Sep 28, 2023
@ShatilKhan
Copy link

can you please assign this issue to me?

@AkshayaFoiger AkshayaFoiger removed the S-awaiting-triage Status: New issues that have not been assessed yet label Sep 28, 2023
@AkshayaFoiger AkshayaFoiger added the S-awaiting-triage Status: New issues that have not been assessed yet label Sep 28, 2023
@AkshayaFoiger
Copy link
Contributor

Hey @ShatilKhan , I see that you're already assigned to #2241 and are working on it. For now, we'll leave this issue open to any other interested contributors. You may pick this up once your work on #2241 is completed, and if no other contributors have expressed interest on this. I hope that's fine by you

@sudharsangs
Copy link
Contributor

Can I pick this issue?

@AkshayaFoiger AkshayaFoiger removed the S-awaiting-triage Status: New issues that have not been assessed yet label Oct 4, 2023
@AkshayaFoiger
Copy link
Contributor

Hey @sudharsangs, sure! I've assigned this to you.

In case you have any queries, you can ask them on this issue thread, or on our discord server, or on slack whichever you are comfortable with

@VedantKhairnar
Copy link
Collaborator

Hey @sudharsangs ,
Let us know if you face any issues. Happy to help! : )

@sudharsangs
Copy link
Contributor

Hey @VedantKhairnar I haven't started working on it yet, I'll be doing it today evening. Will definitely reach out if any help is required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement good first issue Good for newcomers hacktoberfest Issues that are up for grabs for Hacktoberfest participants
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants