Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Implement MerchantAccountInterface for MockDb #2438

Open
Tracked by #172
SanchithHegde opened this issue Oct 3, 2023 · 10 comments
Open
Tracked by #172

[FEATURE] Implement MerchantAccountInterface for MockDb #2438

SanchithHegde opened this issue Oct 3, 2023 · 10 comments
Assignees
Labels
A-framework Area: Framework C-feature Category: Feature request or enhancement good first issue Good for newcomers hacktoberfest Issues that are up for grabs for Hacktoberfest participants help wanted Extra attention is needed

Comments

@SanchithHegde
Copy link
Member

Spin off from #172. Refer to the parent issue for more information

@SanchithHegde SanchithHegde added A-framework Area: Framework C-feature Category: Feature request or enhancement good first issue Good for newcomers help wanted Extra attention is needed labels Oct 3, 2023
@dalprahcd
Copy link
Contributor

Hello @SanchithHegde, I would like to help with this issue.

@SanchithHegde SanchithHegde added the hacktoberfest Issues that are up for grabs for Hacktoberfest participants label Oct 4, 2023
@VedantKhairnar
Copy link
Collaborator

Hey @dalprahcd ,
Let us know if you face any issues. Happy to help! : )

@imSanko
Copy link

imSanko commented Oct 5, 2023

@dalprahcd I'm looking up with adding few changes in this directory if you can kindly assign this issue to me or let me know if a PR will be better to review my work or not!!

@dalprahcd
Copy link
Contributor

Hey @dalprahcd , Let us know if you face any issues. Happy to help! : )

Thanks! I will let you know if I face any difficulties.

@dalprahcd I'm looking up with adding few changes in this directory if you can kindly assign this issue to me or let me know if a PR will be better to review my work or not!!

Hello @imSanko, I want to help with this implementation, you are welcome to do any changes you want (as long as you don't implement MerchantAccountInterface for MockDb), and I can always merge with your changes.

@VedantKhairnar
Copy link
Collaborator

Hey @dalprahcd ,
Just checking in - are you working on it?
Let us know if you need any help.

@dalprahcd
Copy link
Contributor

Hello @VedantKhairnar, yes I am, I will have a PR for it soon, thanks.

@dalprahcd
Copy link
Contributor

Hello @SanchithHegde and @VedantKhairnar,

Looks like I will not be able to help with this implementation. My knowledge of Rust still not there.
I could only implement delete_merchant_account_by_merchant_id:

    async fn delete_merchant_account_by_merchant_id(
        &self,
        merchant_id: &str,
    ) -> CustomResult<bool, errors::StorageError> {
        let mut accounts = self.merchant_accounts.lock().await;
        let index = accounts
            .iter()
            .position(|account| account.merchant_id == merchant_id)
            .ok_or::<errors::StorageError>(errors::StorageError::ValueNotFound(format!(
                "No merchant account found for merchant_id = {merchant_id}"
            )))?;
        accounts.remove(index);
        Ok(true)
    }

Anyone is welcome to take over from now on.

@dalprahcd dalprahcd removed their assignment Oct 17, 2023
@Sangamesh26
Copy link
Contributor

Hey @dalprahcd, please let me know, if you want any kind of help.
If you wanna continue with this implementation, I will help you out.
Please join our discord server and ping in the channel (#dev-help-oss-contrib)

Happy to help :)

@shivansh-bhatnagar18
Copy link
Contributor

Dear Authors, Please Assign me this issue, I would love to help

@VedantKhairnar
Copy link
Collaborator

Hey @shivansh-bhatnagar18 , sure! I've assigned this to you.

In case you have any queries, you can ask them on this issue thread, or on our discord server, or on slack whichever you are comfortable with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-framework Area: Framework C-feature Category: Feature request or enhancement good first issue Good for newcomers hacktoberfest Issues that are up for grabs for Hacktoberfest participants help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants