Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR]: [Zen] MCA metadata validation #2913

Closed
2 tasks done
swangi-kumari opened this issue Nov 17, 2023 · 4 comments
Closed
2 tasks done

[REFACTOR]: [Zen] MCA metadata validation #2913

swangi-kumari opened this issue Nov 17, 2023 · 4 comments
Assignees
Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor good first issue Good for newcomers help wanted Extra attention is needed

Comments

@swangi-kumari
Copy link
Contributor

📝 Feature Description

  • We don't have validation for MCA metadata, So while creating MCA we are allowing any json value. Because of which RequestEncodingFailure happening during payments for the MCA which doesn't have the expected fields

🔨 Possible Implementation

📦 Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

📦 Have you read the Contributing Guidelines?

✨ Are you willing to submit a PR?

@swangi-kumari swangi-kumari added A-connector-integration Area: Connector integration C-refactor Category: Refactor good first issue Good for newcomers labels Nov 17, 2023
@VedantKhairnar VedantKhairnar added the help wanted Extra attention is needed label Nov 23, 2023
@alpha951
Copy link

Hi, I would like to work on this issue.

@SanchithHegde
Copy link
Member

Sure @alpha951. In case of queries, feel free to reach out on this issue thread or on our Discord server.

@alpha951
Copy link

alpha951 commented Feb 25, 2024

@swangi-kumari What is expected metadata format for MCA creation. According to postman collection it's :

  "metadata": {
    "city": "NY",
    "unit": "245"
  }

Also I believe I need to validate the metadata at this line

PS: I'm coming from Java and JS, totally new to Rust so expect some silly questions coming.

@AkshayaFoiger
Copy link
Contributor

Resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants