Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connector enums for Routing in add_connector script [BUG] #2961

Closed
2 tasks done
srujanchikke opened this issue Nov 23, 2023 · 0 comments · Fixed by #2994
Closed
2 tasks done

Add connector enums for Routing in add_connector script [BUG] #2961

srujanchikke opened this issue Nov 23, 2023 · 0 comments · Fixed by #2994
Assignees
Labels
C-bug Category: Bug

Comments

@srujanchikke
Copy link
Contributor

Bug Description

Recently, routing has been moved to OSS. This change breaks the add_connector script. Connector Enums should be added in euclid enums .

Expected Behavior

after running bash add_connector.sh <connector-name> <connector-base-url> code needs to be compiled after template code is created.

Actual Behavior

compilation error before template code is generated because missing connector enums in Routing .

Steps To Reproduce

Provide an unambiguous set of steps to reproduce this bug. Include code or configuration to reproduce, if relevant.

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
    run bash add_connector.sh <connector-name> <connector-base-url> to create new connector template code .This would throw errors in following files
    crates/api_models/src/routing.rs:290:30
    crates/api_models/src/enums.rs:168:5

Context For The Bug

No response

Environment

Are you using hyperswitch hosted version? Yes/No
If yes, please provide the value of the x-request-id response header to help us debug your issue.

If not (or if building/running locally), please provide the following details:

  1. Operating System or Linux distribution:
  2. Rust version (output of rustc --version): ``
  3. App version (output of cargo r --features vergen -- --version): ``

Have you spent some time checking if this bug has been raised before?

  • I checked and didn't find a similar issue

Have you read the Contributing Guidelines?

Are you willing to submit a PR?

Yes, I am willing to submit a PR!

@srujanchikke srujanchikke added C-bug Category: Bug S-awaiting-triage Status: New issues that have not been assessed yet labels Nov 23, 2023
@srujanchikke srujanchikke linked a pull request Nov 28, 2023 that will close this issue
15 tasks
@srujanchikke srujanchikke self-assigned this Nov 28, 2023
@SanchithHegde SanchithHegde removed the S-awaiting-triage Status: New issues that have not been assessed yet label Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Bug
Projects
No open projects
Status: Merged
Development

Successfully merging a pull request may close this issue.

2 participants