Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] Enable runtime flag for s3 feature #3338

Closed
4 tasks done
Chethan-rao opened this issue Jan 12, 2024 · 0 comments · Fixed by #3348
Closed
4 tasks done

[REFACTOR] Enable runtime flag for s3 feature #3338

Chethan-rao opened this issue Jan 12, 2024 · 0 comments · Fixed by #3348
Assignees
Labels
C-refactor Category: Refactor

Comments

@Chethan-rao
Copy link
Contributor

Chethan-rao commented Jan 12, 2024

Feature Description

Tracking issue for refactoring s3 to include compile time + runtime time flag

Current implementation - We are building 2 docker images, one image contains all the release features including kms, s3, etc and other without these features which are getting pushed to the public docker hub. This was to ensure that anyone who wants to try out Hyperswitch locally by pulling the pre-built docker image, it shouldn't be a hassle for he/she to setup s3. For this very reason we were pushing 2 docker images which was a temporary solution

Possible Implementation

Providing support for enabling or disabling s3 feature in runtime so that we no longer have to build 2 images.

Tasks

Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

Have you read the Contributing Guidelines?

Are you willing to submit a PR?

Yes, I am willing to submit a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-refactor Category: Refactor
Projects
None yet
1 participant