Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] add a configuration validation for workers #3510

Closed
dracarys18 opened this issue Jan 31, 2024 · 2 comments · Fixed by #3533
Closed

[FIX] add a configuration validation for workers #3510

dracarys18 opened this issue Jan 31, 2024 · 2 comments · Fixed by #3533
Assignees
@ravikiran232
Labels
good first issue Good for newcomers

Comments

@dracarys18
Copy link
Member

dracarys18 commented Jan 31, 2024 •
edited

We don't have a validation check
number of workers in our config . But if the number of workers is zero actix straight out panics. Ref: https://docs.rs/actix-web/latest/actix_web/struct.HttpServer.html#method.workers
@dracarys18 dracarys18 added the good first issue Good for newcomers label Jan 31, 2024
@ravikiran232
Copy link
Contributor

Hi, I would like to work on this issue.

@dracarys18
Copy link
Member Author

Hi @ravikiran232 assigning the issue to you

@ravikiran232 ravikiran232 mentioned this issue Feb 2, 2024
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ravikiran232 ravikiran232

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(router): added validation check to number of workers in config ravikiran232/hyperswitch
2 participants
@dracarys18 @ravikiran232