Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: add offset field to mandates list #3748

Closed
2 tasks done
Narayanbhat166 opened this issue Feb 21, 2024 · 3 comments · Fixed by #3923
Closed
2 tasks done

[FEATURE]: add offset field to mandates list #3748

Narayanbhat166 opened this issue Feb 21, 2024 · 3 comments · Fixed by #3923
Labels
C-feature Category: Feature request or enhancement good first issue Good for newcomers

Comments

@Narayanbhat166
Copy link
Member

Feature Description

The mandates list endpoint currently has no field to specify offset, which would skip certain number of entries from the start. This is necessary in order to provide pagination support.

Possible Implementation

accept a field called offset which specifies the number of items to skip from the start.

This would be similar to the payments_list pagination. Refer here

Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

Have you read the Contributing Guidelines?

Are you willing to submit a PR?

None

@Narayanbhat166 Narayanbhat166 added C-feature Category: Feature request or enhancement S-awaiting-triage Status: New issues that have not been assessed yet good first issue Good for newcomers labels Feb 21, 2024
@Narayanbhat166 Narayanbhat166 changed the title [FEATURE]: add pagination support for mandates list [FEATURE]: addoffset field to mandates list Feb 21, 2024
@Narayanbhat166 Narayanbhat166 removed the S-awaiting-triage Status: New issues that have not been assessed yet label Feb 21, 2024
@Narayanbhat166 Narayanbhat166 changed the title [FEATURE]: addoffset field to mandates list [FEATURE]: add offset field to mandates list Feb 21, 2024
@neithanmo
Copy link

@Narayanbhat166 you described a possible implementation that consists of adding an offset field to that endpoint method, but after looking at it I noticed that it also takes a payload argument of type: MandateListConstrains.
This led me to ask myself why not make this offset part of the constraints? doing so would allow us to keep the endpoint signature as it is.

can you provide feedback about this option?
I guess an offset is completely unrelated to what a constraint is regarding MandateList and the way the user is querying it.

@PanGan21
Copy link
Contributor

PanGan21 commented Mar 3, 2024

Hi @Narayanbhat166 since this issue was not assigned to someone I did some work on #3923
Please let me know if something could be improved :)

@Narayanbhat166
Copy link
Member Author

This led me to ask myself why not make this offset part of the constraints

Hey @neithanmo, yes you can add it to the constraints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: Feature request or enhancement good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants