Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Separate out totp completion from verify #4730

Closed
Riddhiagrawal001 opened this issue May 22, 2024 · 0 comments · Fixed by #4731
Closed

refactor: Separate out totp completion from verify #4730

Riddhiagrawal001 opened this issue May 22, 2024 · 0 comments · Fixed by #4731
Assignees
@Riddhiagrawal001

Comments

@Riddhiagrawal001
Copy link
Contributor

Currently,verify_totp is the terminating 2fa API and also it was setting the TOTP status as "SET".

So , we want to separate the logic of terminating the 2FA to a separate API so that the job of the verify_totp API will only be to verify if the totp is valid or not which will also help in reusing it inside dashboard.
@Riddhiagrawal001 Riddhiagrawal001 self-assigned this May 22, 2024
@Riddhiagrawal001 Riddhiagrawal001 mentioned this issue May 22, 2024
Merged
14 tasks
@ThisIsMani ThisIsMani linked a pull request May 23, 2024 that will close this issue
feat(users): Create terminate 2fa API #4731
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Riddhiagrawal001 Riddhiagrawal001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(users): Create terminate 2fa API juspay/hyperswitch
1 participant
@Riddhiagrawal001