Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(router): add new payment methods for Bank redirects, BNPL and wallet #864

Merged
merged 17 commits into from
Apr 20, 2023
Merged

feat(router): add new payment methods for Bank redirects, BNPL and wallet #864

merged 17 commits into from
Apr 20, 2023

Conversation

ArjunKarthik
Copy link
Contributor

@ArjunKarthik ArjunKarthik commented Apr 12, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

Description

Add support for new payment methods like AliPay, Blik, MBPay, MobilePay, OnlineBankingCzechRepublic, OnlineBankingFinland, OnlineBankingSlovakia, PayBright, Przelewy24, Swish, Trustly, Walley, AliPay, BancontactCard, MBPay, MobilePay

This doesn't involves any migrations changes as in DB values are handled as varchar and in application it is handled as enum.

Additional Changes

  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Add support for new payment methods like AliPay, Blik, MBPay, MobilePay, OnlineBankingCzechRepublic, OnlineBankingFinland, OnlineBankingSlovakia, PayBright, Przelewy24, Swish, Trustly, Walley, AliPay, BancontactCard, MBPay, MobilePay

How did you test it?

Testing not required, as only new payment methods were introduced in this PR. Tests will be added in future PR's which will have the implementations of newly introduced PaymentMethods.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@ArjunKarthik
feat(router): add support for new payment methods AliPay, Blik, MBPay…
4bbfd06 
…, MobilePay, OnlineBankingCzechRepublic, OnlineBankingFinland, OnlineBankingSlovakia, PayBright, Przelewy24, Swish, Walley
@ArjunKarthik
Merge branch 'main' of https://github.com/juspay/hyperswitch into ady…
775254b 
…en-new-payment-methods
@ArjunKarthik ArjunKarthik added A-connector-compatibility Area: Connector compatibility C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 12, 2023
@ArjunKarthik ArjunKarthik requested review from a team as code owners April 12, 2023 11:08
@ArjunKarthik ArjunKarthik self-assigned this Apr 12, 2023
@ArjunKarthik ArjunKarthik changed the title Adyen new payment methods feat(router): add support for new payment methods AliPay, Blik, MBPay, MobilePay, OnlineBankingCzechRepublic, OnlineBankingFinland, OnlineBankingSlovakia, PayBright, Przelewy24, Swish, Walley Apr 12, 2023
@ArjunKarthik ArjunKarthik changed the title feat(router): add support for new payment methods AliPay, Blik, MBPay, MobilePay, OnlineBankingCzechRepublic, OnlineBankingFinland, OnlineBankingSlovakia, PayBright, Przelewy24, Swish, Walley feat(router): add new payment methods for Bank redirects, BNPL and wallet Apr 12, 2023
@ArjunKarthik ArjunKarthik added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 12, 2023
@ArjunKarthik ArjunKarthik added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 12, 2023
Narayanbhat166
Narayanbhat166 previously approved these changes Apr 12, 2023
View reviewed changes
jarnura
jarnura requested changes Apr 13, 2023
View reviewed changes
Copy link
Member

@jarnura jarnura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should log the payment method for better debugging purpose in the places we are discarding the variant and adding the Not-implemented error.

crates/router/src/connector/trustpay/transformers.rs Show resolved Hide resolved
crates/router/src/connector/trustpay/transformers.rs Show resolved Hide resolved
@jarnura jarnura added this to the April'23 release milestone Apr 14, 2023
@ArjunKarthik ArjunKarthik added M-api-contract-changes Metadata: This PR involves API contract changes A-core Area: Core flows and removed A-connector-compatibility Area: Connector compatibility labels Apr 14, 2023
jarnura
jarnura previously approved these changes Apr 17, 2023
View reviewed changes
@jarnura jarnura added the S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners label Apr 17, 2023
@jarnura jarnura added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners labels Apr 19, 2023
@jarnura jarnura added this pull request to the merge queue Apr 20, 2023
Merged via the queue into main with commit 304081c Apr 20, 2023
@SanchithHegde SanchithHegde deleted the adyen-new-payment-methods branch April 21, 2023 04:57
@manojradhakrishnan manojradhakrishnan mentioned this pull request Apr 21, 2023
Closed
4 tasks
@Gnanasundari24 Gnanasundari24 mentioned this pull request Apr 21, 2023
Merged
@Gnanasundari24 Gnanasundari24 added the M-configuration-changes Metadata: This PR involves configuration changes label Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagan-jaya jagan-jaya jagan-jaya approved these changes

@jarnura jarnura jarnura approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

Assignees

@ArjunKarthik ArjunKarthik

Labels
A-core Area: Core flows C-feature Category: Feature request or enhancement M-api-contract-changes Metadata: This PR involves API contract changes M-configuration-changes Metadata: This PR involves configuration changes
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
April 2023 Release
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ArjunKarthik @jagan-jaya @jarnura @Narayanbhat166 @SanchithHegde @Gnanasundari24