-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(router): add new payment methods for Bank redirects, BNPL and wallet #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, MobilePay, OnlineBankingCzechRepublic, OnlineBankingFinland, OnlineBankingSlovakia, PayBright, Przelewy24, Swish, Walley
…en-new-payment-methods
…en-new-payment-methods
Narayanbhat166
previously approved these changes
Apr 12, 2023
jarnura
requested changes
Apr 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should log the payment method for better debugging purpose in the places we are discarding the variant and adding the Not-implemented error.
…en-new-payment-methods
…ard, MBPay, MobilePay
jarnura
previously approved these changes
Apr 17, 2023
…en-new-payment-methods
…/hyperswitch into adyen-new-payment-methods
jagan-jaya
approved these changes
Apr 18, 2023
Narayanbhat166
approved these changes
Apr 18, 2023
jarnura
approved these changes
Apr 18, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-core
Area: Core flows
C-feature
Category: Feature request or enhancement
M-api-contract-changes
Metadata: This PR involves API contract changes
M-configuration-changes
Metadata: This PR involves configuration changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Add support for new payment methods like AliPay, Blik, MBPay, MobilePay, OnlineBankingCzechRepublic, OnlineBankingFinland, OnlineBankingSlovakia, PayBright, Przelewy24, Swish, Trustly, Walley, AliPay, BancontactCard, MBPay, MobilePay
This doesn't involves any migrations changes as in DB values are handled as varchar and in application it is handled as enum.
Additional Changes
Motivation and Context
Add support for new payment methods like AliPay, Blik, MBPay, MobilePay, OnlineBankingCzechRepublic, OnlineBankingFinland, OnlineBankingSlovakia, PayBright, Przelewy24, Swish, Trustly, Walley, AliPay, BancontactCard, MBPay, MobilePay
How did you test it?
Testing not required, as only new payment methods were introduced in this PR. Tests will be added in future PR's which will have the implementations of newly introduced PaymentMethods.
Checklist
cargo +nightly fmt --all
cargo clippy