feat(compatibility): add refund retrieve endpoint which accepts gateway creds #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-refund-sync-with-gateway-creds-stripe-compatibility
Abhicodes-crypto
added
A-connector-compatibility
2 tasks
SanchithHegde
changed the title
| @@ -49,6 +49,47 @@ pub async fn refund_create( | |||
| .await | |||
| } | |||
|
|
|||
| #[instrument(skip_all)] | |||
| #[get("/{refund_id}")] | |||
There was a problem hiding this comment.
Would this have to be /sync @Abhicodes-crypto? As far as I remember, trying to register two handlers for the same route with the same HTTP method would cause the Actix server to panic at startup.
| @@ -49,6 +49,47 @@ pub async fn refund_create( | |||
| .await | |||
| } | |||
|
|
|||
| #[instrument(skip_all)] | |||
| #[get("/{refund_id}")] | |||
There was a problem hiding this comment.
The route should be post("/sync").
Abhicodes-crypto
suggested changes
Apr 22, 2023
SanchithHegde
approved these changes
Apr 22, 2023
SanchithHegde
added
the
S-waiting-on-review
Abhicodes-crypto
approved these changes
Apr 22, 2023
jarnura
approved these changes
Apr 24, 2023
jarnura
added
S-ready-for-merge
and removed
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR is based on the issue #920 to add refund sync with gateway creds in stripe compatibility.
Adds a new service refund_retrieve_with_gateway_creds which parses the JSON to type RefundsRetrieveRequest which already has an optional field merchant_connector_details to accept gateway credentials and then calls the normal refund retrieve API
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy