Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are we overriding grafana? #128

Closed
srid opened this issue Mar 7, 2024 · 0 comments · Fixed by #131
Closed

Why are we overriding grafana? #128

srid opened this issue Mar 7, 2024 · 0 comments · Fixed by #131

Comments

@srid
Copy link
Collaborator

srid commented Mar 7, 2024

There should be comment in this file saying why we must maintain our own grafana package:

https://github.com/juspay/services-flake/blob/main/test/overlays/grafana.nix


Such a comment already exists on pgAdmin:

# Because tests are failing on darwin: https://github.com/juspay/services-flake/pull/115#issuecomment-1970467684
pgadmin4 = prev.pgadmin4.overrideAttrs (_: { doInstallCheck = false; });

(Though here, this overlay should only apply on darwin).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant