Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clickhouse: extraConfig should be an attrset #92

Closed
srid opened this issue Feb 6, 2024 · 0 comments · Fixed by #99
Closed

clickhouse: extraConfig should be an attrset #92

srid opened this issue Feb 6, 2024 · 0 comments · Fixed by #99
Labels
good first issue Good for newcomers

Comments

@srid
Copy link
Collaborator

srid commented Feb 6, 2024

extraConfig = lib.mkOption {
type = types.lines;
description = "Additional configuration to be appended to `clickhouse-config.yaml`.";
default = "";
};

This type makes the user specify raw config (an error-prone process as well):

      services.clickhouse."clickhouse-db" = {
        extraConfig = ''
          http_port: 8123
        '';
      };

But ideally it should be using freeformType (pkgs.formats.yaml). See example here. Because, then the user can just write:

      services.clickhouse."clickhouse-db" = {
        extraConfig.http_port = 8123;
      };
@srid srid changed the title clickhouse: extraConfig should clickhouse: extraConfig should be an attrset Feb 6, 2024
@srid srid added the good first issue Good for newcomers label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant