Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write examples #2

Open
jussi-kalliokoski opened this issue Aug 5, 2014 · 10 comments
Open

Write examples #2

jussi-kalliokoski opened this issue Aug 5, 2014 · 10 comments

Comments

@jussi-kalliokoski
Copy link
Owner

No description provided.

@irvinebroque
Copy link

Would love to see some examples!

@bermi
Copy link

bermi commented Sep 29, 2014

Some examples would really help understanding how integrate this component.

I'm looking at the tests but it's taking me a lot of trial and error and code peeking to understand how to dimension and style the UI. An example would help to understand how pageHeight, pageWidth, embedHeight, embedWidth, top, left, width and height should be defined (if they need to be defined at all).

@jussi-kalliokoski
Copy link
Owner Author

I'll write some as soon as possible! Thanks for the interest in this component!

@bitsofalex
Copy link

This looks like it is going to be a great component. Any chance of an example?

@aearly
Copy link

aearly commented Oct 6, 2014

👍 for examples

@shilpan
Copy link

shilpan commented Oct 8, 2014

examples please :)

@jehoshua02
Copy link

We've been through several sliders already. Getting tired of the wonky bugs. Looking for something with proven stability and simplicity. Some examples would really be nice.

@jussi-kalliokoski
Copy link
Owner Author

Sorry for the long wait on this one. Anyway, I put up the first example on the new website: http://jussi-kalliokoski.github.io/merry-go-round/examples/basic/ . I'll be adding more examples soon now that I have the basic setup done. The website looks hideous right now, so I'll be happy to accept PRs to make it prettier, and also if people want to write more examples or other improvements to the website, that would be greatly appreciated. :)

@tomvdv
Copy link

tomvdv commented Feb 1, 2015

+1, an updated and full-featured demo suite would stimulate community participation.

@oiva
Copy link

oiva commented May 3, 2015

The example looked super confusing until I realised the MyCarousel render function was missing its return statement which can be found here:

return (
    React.createElement(Carousel, {
        pages: pages,
        pageIndex: this.state.pageIndex,
        previousPageIndex: this.state.previousPageIndex,
        width: width,
        height: height,
        embedWidth: MARGIN,
        embedHeight: 0,
        pageView: Page,
        pageWidth: pageWidth,
        pageHeight: height,
        onSwiped: this.handleSwipe,
        loop: true
    })
);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants