New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write examples #2
Comments
Would love to see some examples! |
Some examples would really help understanding how integrate this component. I'm looking at the tests but it's taking me a lot of trial and error and code peeking to understand how to dimension and style the UI. An example would help to understand how pageHeight, pageWidth, embedHeight, embedWidth, top, left, width and height should be defined (if they need to be defined at all). |
I'll write some as soon as possible! Thanks for the interest in this component! |
This looks like it is going to be a great component. Any chance of an example? |
👍 for examples |
examples please :) |
We've been through several sliders already. Getting tired of the wonky bugs. Looking for something with proven stability and simplicity. Some examples would really be nice. |
Sorry for the long wait on this one. Anyway, I put up the first example on the new website: http://jussi-kalliokoski.github.io/merry-go-round/examples/basic/ . I'll be adding more examples soon now that I have the basic setup done. The website looks hideous right now, so I'll be happy to accept PRs to make it prettier, and also if people want to write more examples or other improvements to the website, that would be greatly appreciated. :) |
+1, an updated and full-featured demo suite would stimulate community participation. |
The example looked super confusing until I realised the MyCarousel render function was missing its return statement which can be found here: return (
React.createElement(Carousel, {
pages: pages,
pageIndex: this.state.pageIndex,
previousPageIndex: this.state.previousPageIndex,
width: width,
height: height,
embedWidth: MARGIN,
embedHeight: 0,
pageView: Page,
pageWidth: pageWidth,
pageHeight: height,
onSwiped: this.handleSwipe,
loop: true
})
); |
No description provided.
The text was updated successfully, but these errors were encountered: