Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this correct? #10

Closed
uuaing opened this issue Oct 13, 2017 · 9 comments
Closed

Is this correct? #10

uuaing opened this issue Oct 13, 2017 · 9 comments

Comments

@uuaing
Copy link
Contributor

uuaing commented Oct 13, 2017

In GameDateParser.hpp, we have this in readyPlayers(), the m_playerCount is really a big number as I debugged, actually it's m_address, it should be no more than 100, correct?
for (int i = 0; i < m_playerCount; i++)

@jussihi
Copy link
Owner

jussihi commented Oct 13, 2017

The name should be m_actorCount, it counts all the actors that are in the array currently. It can grow even to > 1000. Are you having issues with it?

@uuaing
Copy link
Contributor Author

uuaing commented Oct 13, 2017

Yes, I do have issue with m_playerCount as it's too big, will try m_actorCount later, for now I manually set the value to 1000 for the loop, it running well.

@jussihi
Copy link
Owner

jussihi commented Oct 13, 2017

No! It is the right value, but its naming is bad in my code.

It should be between 50-1000 about. Are you having problems related to this?

@uuaing
Copy link
Contributor Author

uuaing commented Oct 13, 2017

Yes, I got a value like 2324443545454, almost this, not exactly.

@jussihi
Copy link
Owner

jussihi commented Oct 13, 2017

That is the value of the "base" ?

If that is really the m_playerCount then maybe the offsets are off?

@jussihi
Copy link
Owner

jussihi commented Oct 13, 2017

I have updated the code, please test with the corrections!

20a3689

@jerrytang67
Copy link

my m_playerCount is 529

@uuaing
Copy link
Contributor Author

uuaing commented Oct 13, 2017

It works, now the number is reasonable, around 300 to 1500.

@jussihi
Copy link
Owner

jussihi commented Oct 13, 2017

OK good, closing this issue.

@jussihi jussihi closed this as completed Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants