Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @dandi/core dependency on fs-extra #12

Closed
2 tasks done
DanielSchaffer opened this issue Oct 1, 2018 · 0 comments
Closed
2 tasks done

Remove @dandi/core dependency on fs-extra #12

DanielSchaffer opened this issue Oct 1, 2018 · 0 comments
Assignees
@DanielSchaffer
Labels
feature New feature or request
Milestone
v1.0.0

Comments

@DanielSchaffer
Copy link
Contributor

DanielSchaffer commented Oct 1, 2018 •
edited

fs-extra is only used by FileSystemScanner, but prevents @dandi/core and anything dependent on it from being used in the browser.

  • Create new @dandi/core-node package
  • Move FileSystemScanner into @dandi/core-node, remove fs-extra dependency
@DanielSchaffer DanielSchaffer added the feature New feature or request label Oct 1, 2018
@DanielSchaffer DanielSchaffer added this to the v1.0.0 milestone Oct 1, 2018
@DanielSchaffer DanielSchaffer mentioned this issue Oct 1, 2018
Closed
2 tasks
@DanielSchaffer DanielSchaffer self-assigned this Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielSchaffer DanielSchaffer

Labels
feature New feature or request
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@DanielSchaffer