-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Angular v10 #781
Comments
Main issue is I upgrade all my deps to ~10 quickfix for users |
Ah! I am indeed hitting the So are you saying that the warnings will disappear when package updates to Angular v10? |
@qortex yes, this poackage has not hitted deps from parrent so its create his local node_modules targeting verzion ~9 i put to my package.json temporary
and app work well tested on big app with 400chunks |
Ok I see, thanks. So I guess the fix would involve updating this file to new dependencies: https://github.com/just-jeb/angular-builders/blob/master/packages/custom-webpack/package.json |
You guys are fast |
You're welcome to try the latest beta |
I confirm it works fine in my setup. Thanks for the very quick patch! |
work like a charm |
After update to
|
I encountered a Cannot find module webpack after rebuilding my app using the beta version. A quick I confirm that the fix specified in the beta works to address the warnings. Thank you very much ! :) |
But now my Heroku builds don't pass anymore :(
and then nothing, and it times out. Any idea why that would be happening, or a way to debug? |
@piotrroda did you try clean install? Removing node modules and etc.? @lhargil same question. |
Yes i did a clean install after updating to the beta. As mentioned, the |
Also can confirm on my CI, with beta deps halting with "cannot find module webpack" as is mention above |
Do you have |
I had the same problem but I can confirm with version |
Turns out it's an "out-of-memory" on my heroku builder. |
Alright, the memory issue turned out to be a (very much!) non-trivial bug in It appears only if differential loading is disabled ans was actually already there in v9. A patch will be released upstream. Note: during the investigation, the Angular team member saw that my builds involve what seems to be a lot of webpack compilations (121). Any tip on if it's normal or due to a misconfig of |
I had the same issue with What I ended up doing (and worked) was:
I can't say for sure this will work on the first try, as I did some of the steps multiple times, but eventually, it worked without npm link. |
Inspired by @danmana's message, wiping |
I needed to update to |
Any news about v10 stable release? |
Just published. |
Thank you @just-jeb ! :) |
To The alternative solution which worked for me was uninstalling Note: Removing |
After migrating to Angular v10:
The text was updated successfully, but these errors were encountered: