Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2.0 Feature: Permissions #7

Closed
imayhaveborkedit opened this issue Jan 7, 2016 · 3 comments
Closed

V2.0 Feature: Permissions #7

imayhaveborkedit opened this issue Jan 7, 2016 · 3 comments

Comments

@imayhaveborkedit
Copy link
Collaborator

Currently any user can use any command, and this is obviously sub optimal for any setting other than a group of friends. Denying users access to certain commands is obviously necessary for more public settings. This issue is twofold: the implementation of the internal permissions system, and how the user access it. Other variations are still a possibility.

  • Option 1: Internalize Everything
    • Using this method means that commands will be assigned permission groups in the config, and users will be managed with commands, adding and removing permissions though chat.
    • Alternatively, commands will be marked as needing permission, and users will be permitted to use them via some sort of !permit user style of command.
    • For both variations, these settings will be saved to a file in the musicbot folder.
  • Option 2: Assigning Server Groups
    • Access to certain commands will be permitted through the process of assigning a user a user-defined server group, matching something set in the config. For example:
      • A user would set several commands they want limited to the group DJ, and only users with the group DJ would be able to use those commands.
    • Alternatively, commands would have a predefined identifier, and server groups containing the identifier along with an arbitrary prefix to designate the group is the command group. For example:
      • The skip command would have an identifier of s
      • The volume command would have an identifier of v
      • The command prefix would be botperms-
      • Any user with the group botperms-s would have access to the skip command
      • Any user with the group botperms-v would have access to the volume command
      • Users with the group botperms-sv would have access to both commands
      • This idea was based on the regex flag system. (?iLmsux)
@imayhaveborkedit imayhaveborkedit added this to the MusicBot V2.0 milestone Jan 7, 2016
@imayhaveborkedit imayhaveborkedit added the s/help wanted Does anyone else wanna do this? label Jan 7, 2016
@ArneNaessens
Copy link
Contributor

I would suggest Option 2. Because it's easyer for discord server admins to setup. But probally harder for the coders.

@imayhaveborkedit imayhaveborkedit mentioned this issue Jan 14, 2016
@Arzte
Copy link

Arzte commented Jan 17, 2016

I vote for option 2, discord already has a permissions system, so why not take advantage of it. (its also easier for the server admins like @Cyberstar1 said)

srhinos added a commit that referenced this issue Feb 1, 2016
srhinos added a commit that referenced this issue Feb 1, 2016
… it so it doesn't require perms and added in the suggested ignore features.
@imayhaveborkedit imayhaveborkedit removed the s/help wanted Does anyone else wanna do this? label Feb 4, 2016
@imayhaveborkedit imayhaveborkedit removed this from the MusicBot V2.0 milestone May 22, 2016
@amit177 amit177 closed this as completed Mar 25, 2021
@amit177
Copy link
Member

amit177 commented Mar 25, 2021

Old issue, we already have a permission system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants