Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem modifying .cc files #52

Closed
xAKLx opened this issue Mar 1, 2018 · 6 comments
Closed

Problem modifying .cc files #52

xAKLx opened this issue Mar 1, 2018 · 6 comments

Comments

@xAKLx
Copy link
Contributor

xAKLx commented Mar 1, 2018

When I modify one of the .cc files (utils.cc and utils.h) the changes doesn't affect the build. I know that the build knows about my changes because if I do something wrong, the build throws an error and stop. But after the build, I went to the face-recognition folder inside the node_modules and the .cc file has the original version instead of my edited version. Why does this happen?

Pd: the purpose of my modifications is to use dlib::assign_image to convert a CvImage to an ImageRGB because the face68LandmarkPredictor only works with ImageRGB.

@justadudewhohacks
Copy link
Owner

Hi,

My guess is, if you want to modify the files, you would have to clone this repo. Modifying the files inside node_modules will probably just pull the original files from npm again once you npm install.

@xAKLx
Copy link
Contributor Author

xAKLx commented Mar 1, 2018

Hello,

Yes, I am using a local copy of the repo, and I am requiring it in the package.json like this:
"face-recognition": "file:./face-recognition". But for some reason, what gets to the node_modules is the original version, even though it throws errors during the build(npm install) if I do something wrong.

@justadudewhohacks
Copy link
Owner

Okay, why are you adding a dependency to face-recognition in the package.json of face-recognition itself? That doesn't quite make sense to me. You could just obey that line.

@xAKLx
Copy link
Contributor Author

xAKLx commented Mar 1, 2018

No, I am adding it to the package.json of my personal project, to use the library(local version) there.

@justadudewhohacks
Copy link
Owner

justadudewhohacks commented Mar 1, 2018

Ah I see. Well that's odd. You could try to move the face-recognition package outside of your working directory. I usually do it like "face-recognition": "../face-recognition" when developing locally.

@xAKLx
Copy link
Contributor Author

xAKLx commented Mar 2, 2018

It didn't work even using a git link to my own fork in the dependencies or moving the directory outside. But in the end I copied the files to the node_modules and performed a npm run install inside the directory. Now is working properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants