Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SteamGuard-Code Input (empty) #12

Closed
Pandiora opened this issue Nov 4, 2015 · 1 comment
Closed

SteamGuard-Code Input (empty) #12

Pandiora opened this issue Nov 4, 2015 · 1 comment

Comments

@Pandiora
Copy link
Contributor

Pandiora commented Nov 4, 2015

To avoid problems with SteamGuard I would recommend to jump to next step if you put in empty SteamGuard-Code (just press enter) and abort logon-attempt or retry later. Sometimes I didn´t got any SteamGuard-Mail for no reason and then I had to press enter and the empty code been send to steam. I think this also counts as failed login-attempt and can cause being blocked by steam. Here I just want to lower the risk of being banned for an hour or more.

Additionally w/o checking it - remove of all whitespace-characters (trim) SG-Code-Input. Most of the time I copy SG-Codes theres a space at the end of the string and I have to remove it by myself. But maybe Steam removes this whitespace by themselves - dunno.

@JustArchi
Copy link
Member

This is actually not possible because regardless of what steamguard code you enter, flow is then continued to OnDisconnected() callback, which initiates reconnecting through SteamClient.Connect().

new SteamClient -> Connect -> OnConnected -> Login(without code) -> OnLoggedOn -> EResult.AccountLogonDenied -> OnDisconnected -> Connect -> OnConnected -> Login(with code) -> OnLoggedOn -> EResult.OK

This doesn't work like typical steam client, we actually initiate second Login, just with same steam client so code is not being sent twice. The only thing I could do is spawning totally new steam client if your AuthCode is empty, but then again, it doesn't fix your situation in any way, as new client will once again try to login, get AccountLogonDenied, then do it twice. You're not saving a request here, but complicating things further.

Trimming sounds like a good idea.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants