Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe bot should re-start farm if farming is stuck? #23

Closed
Rudokhvist opened this issue Nov 25, 2015 · 3 comments
Closed

Maybe bot should re-start farm if farming is stuck? #23

Rudokhvist opened this issue Nov 25, 2015 · 3 comments
Labels
🐍 Not a bug Issues marked with this label indicate that given behaviour is intended to happen - not a bug. ❓ Question Issues marked with this label are not issues per-se, but (valid or invalid) development questions.

Comments

@Rudokhvist
Copy link
Contributor

Just to discuss it separately from issue #16.

As @Haoose pointed, it'll skip to the next game, and assume that currently farming game is 100% farmed. It's nice to note that it's only temporary, so as I said, on next CardsFarmer module restart (e.g. triggered by steam disconnect, or cd-key activation), bot will recheck if assumption is proper, and if needed, farm the same ID further. It's a mechanism which tries to detect that cards don't drop for some reason (steam-related).

Maybe it would be better not skip the game, but re-start farming instead? I've met the problem of game stuck for 10+ hours, and I solved it either by restarting bot with !stop and !start, or by giving a !farm command. Why not make this process automatical, and maybe even decrease timeout to 5 hours (no big deal if bot is really still farming, it would just continue after restart.)

@JustArchi
Copy link
Member

As I said bot will resume farming that appID on next module restart.

It's more for games with broken hours reporting, temporary issue we discovered together with @Pandiora , when one game wouldn't drop cards neither update hours played. That was the main reason to implement a module that would skip a game for some time and move onto other ones, and then eventually try the faulty game again on next module restart.

@JustArchi JustArchi added ❓ Question Issues marked with this label are not issues per-se, but (valid or invalid) development questions. 🐍 Not a bug Issues marked with this label indicate that given behaviour is intended to happen - not a bug. labels Nov 25, 2015
@Rudokhvist
Copy link
Contributor Author

Okay, I'll try to investigate this "stuck" games I talking about to find the reasons it happens. Maybe then we'll return to this problem again.

@JustArchi
Copy link
Member

Closing it until then, as there's no bug regarding this, and bot indeed does handle stuck games after 10 hours.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐍 Not a bug Issues marked with this label indicate that given behaviour is intended to happen - not a bug. ❓ Question Issues marked with this label are not issues per-se, but (valid or invalid) development questions.
Projects
None yet
Development

No branches or pull requests

2 participants