Skip to content

Commit

Permalink
Add strong name
Browse files Browse the repository at this point in the history
Strong-name the assembly, and as that is a breaking change, bump the version to 2.0.0.
Also fix the assembly version to "2.0.0.0", and set the file version based on the AppVeyor build number.
  • Loading branch information
martincostello committed Oct 16, 2018
1 parent f3e7be4 commit 30f4b36
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 2 deletions.
5 changes: 4 additions & 1 deletion Directory.Build.props
Expand Up @@ -13,6 +13,7 @@
</ItemGroup>
<PropertyGroup>
<AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>
<AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)justeat-oss.snk</AssemblyOriginatorKeyFile>
<Authors>JUSTEAT_OSS</Authors>
<CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)HttpClientInterception.ruleset</CodeAnalysisRuleSet>
<Company>Just Eat</Company>
Expand All @@ -33,7 +34,9 @@
<RepositoryType>git</RepositoryType>
<RepositoryUrl>$(PackageProjectUrl).git</RepositoryUrl>
<TreatWarningsAsErrors>True</TreatWarningsAsErrors>
<VersionPrefix>1.2.3</VersionPrefix>
<AssemblyVersion>2.0.0.0</AssemblyVersion>
<VersionPrefix>2.0.0</VersionPrefix>
<VersionSuffix></VersionSuffix>
<FileVersion Condition=" '$(APPVEYOR_BUILD_NUMBER)' != '' ">$(VersionPrefix).$(APPVEYOR_BUILD_NUMBER)</FileVersion>
</PropertyGroup>
</Project>
2 changes: 1 addition & 1 deletion appveyor.yml
@@ -1,5 +1,5 @@
os: Visual Studio 2017
version: 1.2.3.{build}
version: 2.0.0.{build}

environment:
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true
Expand Down
Binary file added justeat-oss.snk
Binary file not shown.
Expand Up @@ -6,7 +6,9 @@
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<OutputType>Library</OutputType>
<PackageId>JustEat.HttpClientInterception</PackageId>
<PublicSign Condition=" '$(OS)' != 'Windows_NT' ">true</PublicSign>
<RootNamespace>JustEat.HttpClientInterception</RootNamespace>
<SignAssembly>true</SignAssembly>
<Summary>A .NET library for intercepting server-side HTTP dependencies.</Summary>
<TargetFrameworks>netstandard1.3;netstandard2.0</TargetFrameworks>
<TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">$(TargetFrameworks);net461</TargetFrameworks>
Expand Down

0 comments on commit 30f4b36

Please sign in to comment.