MissingMethodException when running on mono with newer Newtonsoft.Json

[slang25]

This is quite an exotic setup I know, but this has my tests failing in CI, so I'll be looking into this too.

I have an example here:
a776327#diff-ad2944e2db1bf6a75b8602f406da7846R13

When running under mono, if I call .WithJsonContent(... then it pops with a runtime exception:

Error Message:
   System.MissingMethodException : Method not found: JustEat.HttpClientInterception.HttpRequestInterceptionBuilder JustEat.HttpClientInterception.HttpRequestInterceptionBuilderExtensions.WithJsonContent(JustEat.HttpClientInterception.HttpRequestInterceptionBuilder,object,Newtonsoft.Json.JsonSerializerSettings)

In recreating this, I discovered that it's not an issue if you are referencing Newtonsoft.Json 9.0.1, but if you reference a higher version such as 12.x then this issue pops up.

[martincostello]

Yay, breaking changes are fun! 😭

[martincostello]

This is particularly weird as we're happily using 12.0.2 internally in our apps' tests.

[martincostello]

Though we're not using the overload that takes a JsonSerializerSettings.

[slang25]

Also, I've not tried it on windows with Full Framework, it might be a mono only quirk, not sure yet.
Edit: Works on netcoreapp2.x

[martincostello]

Actually we are using that overload, it's just that it's an optional parameter:

https://github.com/justeat/httpclient-interception/blob/fe8ae42cee9f94802421ca4ac32279821075aca6/src/HttpClientInterception/HttpRequestInterceptionBuilderExtensions.cs#L213-L217

[martincostello]

If this is a blocker it'll have to wait until .NET Core 3.0 ships in September, because then we can ship a 3.0.0 of this as a breaking change and remove the dependency on Netwonsoft.Json to give people the option to use System.Text.Json instead.

(And it would be tidier to ship a 3.0 to go with 3.0 😄)

[slang25]

I ideally need a fix soonish, my workaround would be running this on core, but we want mono cause it's the closest thing to xamarin iOS/Android which is our target platform.

That exception tells me it can't find WithJsonContent, so I don't get why the version of newtonsoft has anything to do with it, surely the exception message is wrong and it means some other method?

[martincostello]

Yeah, it's a weird one. Something about optional parameters and/or a change somewhere in 12.x with JsonSerializerSettings?

[martincostello]

I'd be happy to look at doing a beta of a 3.0.0 with changes to decouple Newtonsoft.Json in the soon-ish future (within a week?) and pushing it to NuGet to unblock you though.

[slang25]

That would be amazing, in the meantime if I figure out anything more I'll let you know 😃

[martincostello]

I'll see if I can pick up the above this week.

[martincostello]

See #127 for a fix candidate.

[slang25]

Pulled it down and can confirm this has fixed it 😄 Nice one