Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support conditional interception based on the body #8

Closed
martincostello opened this issue Feb 1, 2018 · 0 comments · Fixed by #9
Closed

Support conditional interception based on the body #8

martincostello opened this issue Feb 1, 2018 · 0 comments · Fixed by #9
Assignees
@martincostello
Labels
enhancement A change that enhances existing functionality or documentation.

Comments

@martincostello
Copy link
Member

Expected behaviour

Enough infrastructure should be available in the library so that a user may elect to read the body before it is sent (at their own risk, for example if it is in a write-only stream) and inform the interception message handler to intercept (or not) a request.

Actual behaviour

While it is possible to intercept the request before it is sent and inspect the body, it is not possible to change whether or not the request is intercepted.
@martincostello martincostello added the enhancement A change that enhances existing functionality or documentation. label Feb 1, 2018
@martincostello martincostello self-assigned this Feb 1, 2018
@martincostello martincostello mentioned this issue Feb 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martincostello martincostello

Labels
enhancement A change that enhances existing functionality or documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support conditional request interception
1 participant
@martincostello