Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There might be an index error in TimeSeries.ipynb #183

Closed
xjxj0322 opened this issue Mar 28, 2024 · 1 comment
Closed

There might be an index error in TimeSeries.ipynb #183

xjxj0322 opened this issue Mar 28, 2024 · 1 comment

Comments

@xjxj0322
Copy link

Thanks a lot for creating and maintaining the minisom package! It helps me a lot in my study and research.
When I was having a try of TimeSeries.ipynb, I found that there might be an index error:

plt.subplot(the_grid[6-position[1], position[0]])

It makes the first row of subplots to appear in the last row.

The quoted line should be corrected to:

plt.subplot(the_grid[7-position[1], position[0]])

Or using:

plt.subplot(8, 8, 8*(8-position[1]-1)+(position[0]+1))

Below is the correct plot.

time_series2

@JustGlowing
Copy link
Owner

Very well spotted! I Just pushed the changes you suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants