Skip to content
This repository has been archived by the owner on Jun 17, 2023. It is now read-only.

Make report_line function signatures consistent across all reporters #88

Merged
merged 1 commit into from Jul 25, 2016

Conversation

harveyr
Copy link
Contributor

@harveyr harveyr commented Jul 24, 2016

It seems like this needs to be done? I'm currently getting this error when running with --no-post:

Traceback (most recent call last):
  File "/mnt/services/jenkins/workspace/imhotep/imhotep/bin/imhotep", line 9, in <module>
    load_entry_point('imhotep==1.0.1', 'console_scripts', 'imhotep')()
  File "/mnt/services/jenkins/workspace/imhotep/imhotep/imhotep/main.py", line 54, in main
    imhotep.invoke()
  File "/mnt/services/jenkins/workspace/imhotep/imhotep/imhotep/app.py", line 135, in invoke
    x, pos_map[x], violations['%s' % x])
TypeError: report_line() takes exactly 7 arguments (6 given)

Here are the signatures before and after the changes:

screen shot 2016-07-24 at 2 08 03 pm
screen shot 2016-07-24 at 2 07 46 pm

Let me know if I misunderstood. Thanks!

@codecov-io
Copy link

codecov-io commented Jul 24, 2016

Current coverage is 97.70% (diff: 100%)

No coverage report found for master at dfe618d.

Powered by Codecov. Last update dfe618d...8d2c43d

@justinabrahms
Copy link
Owner

Thanks so much!

@justinabrahms justinabrahms merged commit 3dc1be2 into justinabrahms:master Jul 25, 2016
@harveyr
Copy link
Contributor Author

harveyr commented Jul 25, 2016

D'oh! I need to fix the interpolation in PrintingReporter.report_line as well. I'll try to PR that first thing tomorrow.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants