Reflect the :conditions option into associations

[sobrinho]

Hello,

I would to request a new feature, reflect the :conditions options into associations. I have a application like that:

class Company < ActiveRecord::Base
  validates_inclusion_of :company_type, :in => %w(group_company customer)
end

class Case < ActiveRecord::Base
  belongs_to :customer, :class_name => 'Company', :conditions => { 'companies.company_type' => 'customer' }
  belongs_to :company, :conditions => { 'companies.company_type' => 'group_company' }
end

And I created a form like that (using HAML):

      - semantic_form_for Case.new do |f|
        - f.inputs do
          = f.input :company, :required => false, :prompt => '- Companies'
          = f.input :customer, :required => false, :prompt => '- Customers'

        - f.buttons do
          = f.submit

But formtastic doesn't reflect the conditions. Well, I arounded that with this:

      - semantic_form_for Case.new do |f|
        - f.inputs do
          = f.input :company, :required => false, :collection => Company.all(:conditions => { :company_type => 'group_company' } }), :prompt => '- Companies'
          = f.input :customer, :required => false, :collection => Company.all(:conditions => { :company_type => 'customer' } }),, :prompt => '- Customers'

        - f.buttons do
          = f.submit

I think that is a great feature and will be very apreciated by users :)

[justinfrench]

Sounds like a good idea!

[grimen]

I guess this is low prio - I never seen one IRL use :conditions on associations, it's really not that common. If it would be a feature, I would suggest to make ValidationReflection plugin more generic...and as I have done some work on ValidationReflection lately, I can say you only have to change a few lines - making it a "ModelReflection" quite easy.

[grimen]

Oh...my bad, no need extend ValidationReflection - everything that's needed is in Rails core:

http://github.com/rails/rails/blob/master/activerecord/lib/active_record/reflection.rb

[anshul]

Just wanted to add +1 to this feature request... It is natural to expect an association's input to honour the association's conditions.

[sobrinho]

I made a initializer for my project: http://gist.github.com/353414

With a good refactoring can be merged on core :)

[justinfrench]

Patch with spec coverage welcome!

[justinfrench]

Sobrinho, should this make it into 1.0, or can it wait?

[sobrinho]

I will do this for 1.0. I think this is important.

I will make the patch with specs on master branch tomorrow.

[sobrinho]

find_raw_collection_for_column should honour the association's conditions

Closed by b5f771a