Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textbox mouseover/out handlers enabling/disabling dragging causes dragging to be enabled when you don't want it to be #21

Open
benglass opened this issue Apr 27, 2016 · 0 comments

Comments

@benglass
Copy link

The textbox html element added by this plugin includes event handlers on mouseover/out that enable/disable dragging on the map.

This is problematic because dragging my be disabled for some other reason. For example Leaflet Draw disables dragging when you start drawing shapes. If you then mouseover and mouseout of a textbox then you re-enable dragging.

I have monkey patched the _enableTyping method in our install to remove those dragging lines and everything works fine, so I'm not sure why they are necessary. If they are not required I can submit a PR to remove them.

https://github.com/justinmanley/Leaflet.Illustrate/blob/master/src/core/L.Illustrate.Textbox.js#L160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant