Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto_activation: 2.5.3 breaks auto-deactivation #211

Closed
4 tasks done
akurtz-penguin opened this issue Sep 3, 2021 · 3 comments
Closed
4 tasks done

auto_activation: 2.5.3 breaks auto-deactivation #211

akurtz-penguin opened this issue Sep 3, 2021 · 3 comments
Labels

Comments

@akurtz-penguin
Copy link

  • I am using Fish shell version 3.1 or higher.

  • I am using Python version 3.6 or higher.

  • I have searched the issues (including closed ones) and believe that this is not a duplicate.

  • If related to a plugin, I prefixed the issue title with the name of the plugin.

  • OS version and name: Ubuntu 20.04

  • Fish shell version: 3.3.1

  • VirtualFish version: 2.5.3

Issue

When using virtualfish 2.5.3 and the auto_activation plugin, cd out of the .venv enabled directory does not disable the virtualenv. cd to another .venv directory does change to the new virtualenv. 2.5.2 works as expected. I am not using the project plugin.

@justinmayer
Copy link
Owner

Can you try the code in existing PR #210 and let me know if that resolves the issue you observed?

@justinmayer
Copy link
Owner

Hi Aaron. Could you test the recently-released 2.5.4 version and see whether that addresses the problem you observed?

@akurtz-penguin
Copy link
Author

2.5.4 fixes the issue, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants