Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"additionalItems" should not be honored if "items" is an object. #333

Open
SereneAnt opened this issue Nov 8, 2016 · 6 comments
Open

"additionalItems" should not be honored if "items" is an object. #333

SereneAnt opened this issue Nov 8, 2016 · 6 comments
Projects

Comments

@SereneAnt
Copy link
Contributor

As per json-schema specification:

if "items" is not present, or its value is an object, validation of the instance always succeeds, regardless of the value of "additionalItems";

Currently (v 4.0.x), CollectionConstraint makes an extra checks for "additionalItems" if "items" is object and fails validation

@shmax
Copy link
Collaborator

shmax commented Jan 29, 2017

Feel free to open a PR

@erayd
Copy link
Contributor

erayd commented Apr 11, 2017

@SereneAnt @shmax Are either of you guys intending to address this, or should I add it to my list?

@erayd
Copy link
Contributor

erayd commented Apr 11, 2017

(Note that I don't consider this a high priority, so if it goes on my list, it may take me a while to get to it).

@SereneAnt
Copy link
Contributor Author

@erayd I'm off this train as for now, sorry. For sure, you'll do it better!

@shmax
Copy link
Collaborator

shmax commented Apr 13, 2017

@erayd I wasn't planning on it, but you've been doing most of the heavy labor around here lately, so if you would like me to look at it I will.

@erayd
Copy link
Contributor

erayd commented Apr 13, 2017

@shmax Feel free if you're in the mood, but no pressure and no rush - this issue is IMO minor, has already been open for five months, and the OP doesn't seem to care.

If you don't feel like doing this, it's not an issue, and I'll probably catch is sometime during my implementation of strict-mode, once we have the rules thing sorted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
v6.0.0
To do
Development

No branches or pull requests

3 participants