Optional extra arguments for custom error messages #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 5, 2015
| { | ||
| $this->errors[] = array( | ||
| $a = array( |
There was a problem hiding this comment.
please don't use such a meaningless names
There was a problem hiding this comment.
Hmm, it's better to use meaningless very short names for variables that are being used temporarily and locally within such a small method, but fine I'll change the name.
There was a problem hiding this comment.
you never know if this method will be larger in the future
|
Needs rebase |
2 tasks
| @@ -7,3 +7,5 @@ coverage | |||
| .settings | |||
| composer.lock | |||
| docs-api | |||
| /.idea | |||
| /composer.phar | |||
There was a problem hiding this comment.
Please move these to you global ignore
|
@onlinesid thanks for the rebase. Would you please squash this down to a single commit? |
…or custom error messages * Added more information to the error message of StringConstraint * Added more information to the Constraint addError * Unknown format does not generate error * Updated the test so that unknown format does not throw an error * Make messages to start with a capital letter consistently
|
I've squashed into a single commit now |
|
@Maks3w what are your thoughts on the the version number to iterate to when this is merged? |
bighappyface
added a commit
that referenced
this pull request
Nov 8, 2015
Optional extra arguments for custom error messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And unknown format no longer generate error