Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(composer): require PHP 5.3.29 (PHP 5.3.x EOL version) minimum #218

Merged
merged 1 commit into from
Jan 18, 2016
Merged

feat(composer): require PHP 5.3.29 (PHP 5.3.x EOL version) minimum #218

merged 1 commit into from
Jan 18, 2016

Conversation

bighappyface
Copy link
Collaborator

With PHP 5.3.x EOL as of 8/14/2014 it is time to remove support for PHP 5.3.x versions prior to the last version.

https://secure.php.net/releases/5_3_29.php

bighappyface added a commit that referenced this pull request Jan 18, 2016
feat(composer): require PHP 5.3.29 (PHP 5.3.x EOL version) minimum
@bighappyface bighappyface merged commit acb3e85 into jsonrainbow:master Jan 18, 2016
@bighappyface bighappyface deleted the remove-php-5-3-3 branch January 18, 2016 20:23
@stof
Copy link

stof commented Feb 5, 2016

given that composer defines the platform php version to 5.3.9 (its min version), it means it will never use 1.6.1+ versions and so won't have bugfixes.
So I suggest reverting the requirement change (there is nothing actually incompatible with older PHP versions in the library AFAICT)

@bighappyface
Copy link
Collaborator Author

Hey folks,

PHP 5.3 is long gone and anything less than 5.3.30 isn't recommended for anyone.

Considering that you, the users, are consuming this package on older platforms, I recommend simply skipping the platform requirements during install:

http://stackoverflow.com/questions/26165101/skip-composer-php-requirement

@stof
Copy link

stof commented Feb 5, 2016

@bighappyface I'm talking about the building of the Composer dependencies themselves, which target the older version.
and the composer requirement is not about a recommended version. It is about a required version. Most projects I maintained are compatible with 5.3+ or 5.4+, but the recommended version is still to use the latest (I would recommend 5.6 or 7 for now, at the latest patch version of course).

@bighappyface
Copy link
Collaborator Author

@stof Checkout #231

We are good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants