Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(travis): pivot to container-based infrastructure #222

Merged
merged 1 commit into from
Jan 25, 2016
Merged

feat(travis): pivot to container-based infrastructure #222

merged 1 commit into from
Jan 25, 2016

Conversation

@bighappyface
Copy link
Collaborator Author

This seems marginally faster than the legacy infrastructure:

Without sudo:false: https://travis-ci.org/justinrainbow/json-schema/builds/104474976

Elapsed time 1 min 58 sec
Total time 12 min 2 sec

With sudo:false: https://travis-ci.org/justinrainbow/json-schema/builds/104475549

Elapsed time 3 min 34 sec
Total time 11 min 29 sec

@bighappyface
Copy link
Collaborator Author

@localheinz thoughts?

@localheinz
Copy link
Contributor

@bighappyface

Faster is better! 👍

@localheinz
Copy link
Contributor

@bighappyface

But sudo is still needed, isn't it?

See https://github.com/justinrainbow/json-schema/blob/master/.travis.yml#L20.

@bighappyface
Copy link
Collaborator Author

@localheinz good question. I removed the CHECK_LINKS environment variable from the PHP 5.6 build to clear up some dependency issues that arose and started breaking the build. You had recommended something along those lines awhile back.

Now that the doc build isn't part of the build process we are good to disable sudo and get things up to date.

bighappyface added a commit that referenced this pull request Jan 25, 2016
feat(travis): pivot to container-based infrastructure
@bighappyface bighappyface merged commit cc84765 into jsonrainbow:master Jan 25, 2016
@bighappyface bighappyface deleted the travis-containers branch January 25, 2016 15:43
@localheinz
Copy link
Contributor

@bighappyface

We could speed up the build even further by

In regard to coverage, maybe it makes sense to use https://codeclimate.com? It's free for open source, and it comes with fancy badges for displaying the code quality as well as coverage!

@bighappyface
Copy link
Collaborator Author

@localheinz +1

Feel free :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants