Throw ResourceNotFoundException outside of re-defined error-handler
#273
Conversation
|
Please avoid all those formatting changes, are noisy, Provide a unit test. |
| }); | ||
| $response = file_get_contents($uri); | ||
| restore_error_handler(); | ||
|
|
||
| if ($error) { | ||
| list (, $errstr, $errfile, $errline) = $error; | ||
| $message = sprintf('%s on line %s in %s', $errstr, $errline, |
There was a problem hiding this comment.
Almost everything in the proposed message template is already present in the stacktrace. $errstr is the only value you need here.
dmitry-varennikov-eventbase
force-pushed
the
uri-retriever-error-handler-2
branch
from
3a8ef5c
to
534f66d
Compare
|
Unit test |
|
@Maks3w https://github.com/justinrainbow/json-schema/pull/273/files?w=1 to exclude white space |
|
This is not about visualization. It's about to keep a clean and organized history. If the CS changes was done in a different PR you didn't have to revert. |
|
@Maks3w I'm starting to question the value of considering your input when you basically have nothing good or nice to say about anything and have contributed little to this project but hyper-criticism. How about you https://m.spreadshirt.com/shut-the-fuck-up-and-write-some-code-t-shirts-A103693056 |
|
@Maks3w What about the "The Boy Scout Rule"? Why you're complaining about this nice PR? |
|
Does this PR require any more code? |
|
+1 |
|
Once this is merged does anyone see any issue with bumping the package to 2.0.5? |
Throwing exception outside of re-defined error-handler allows us to catch it in our app stack