Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with HDR Videos Being Displayed using lite-youtube #53

Open
ryanrbftp opened this issue Feb 9, 2022 · 7 comments
Open

Issue with HDR Videos Being Displayed using lite-youtube #53

ryanrbftp opened this issue Feb 9, 2022 · 7 comments
Assignees
Labels
needs-info Needs additional information to be debugged. possible-crbug Feels like Chrome is mad about something.

Comments

@ryanrbftp
Copy link

Hi there,

We have used the lite-youtube code for some time now. All works wonderfully.

However, we have an issue when embedding videos available in HDR

The videos are completely washed out and much too bright.

Example of lite-youtube embed with HDR video:
Screen Shot 2022-02-09 at 21 58 25

What the actual video should look like (from YouTube):

Screen Shot 2022-02-09 at 21 59 32

We tested with a standard YouTube IFRAME embed of the same video and all works just fine with HDR - it displays correctly.

We were testing on Chrome (latest stable).

@justinribeiro
Copy link
Owner

Humm, that is odd. I've only seen that behavior once before and it was resolved with a point patch in M87 (it seemingly happened randomly, though I don't know if there was a ticket for it upstream). As there isn't anything lite-youtube had changed recently that would cause this, I'll do a little digging and investigate.

@justinribeiro justinribeiro added needs-info Needs additional information to be debugged. possible-crbug Feels like Chrome is mad about something. labels Feb 9, 2022
@justinribeiro justinribeiro self-assigned this Feb 9, 2022
@ryanrbftp
Copy link
Author

If it helps, I have a live example:
https://www.simshack.net/products/handley-page-hampden-x-plane-1887

We are using a slightly older version of lite-youtube however just for testing last night we temporarily applied the latest version (1.3.1) and the issue still produced.

Many thanks for looking into this.

@nmrose101
Copy link

That is actually part of the video. Best way to fix this is to go to final cut and use the HDR filter.

@ryanrbftp
Copy link
Author

That is actually part of the video. Best way to fix this is to go to final cut and use the HDR filter.

I don't think this comment makes any sense. As you can see above, the differences between YouTube direct player and the yt-lite embed on the same video.

@justinribeiro - any update on a fix for this? All the best and thank you for looking into it. Also, we'd be happy to make a donation to your project to ensure continued support of this package. Could you let us know the details?

@nmrose101
Copy link

nmrose101 commented Feb 28, 2022

This is 100% a video problem. Some players like HDR and some don't (Instagram hates it). Here is one knowledge base article on it -- https://support.apple.com/guide/final-cut-pro/convert-or-adjust-hdr-clips-verbf72f3e96/mac

@ryanrbftp
Copy link
Author

@nmrose101

YouTube is fine with HDR.

It's a full, correctly rendered, and produced HDR video we uploaded to YT. The video works fine on YouTube:
https://www.youtube.com/watch?v=LMi2rjziSFU

But not in an lite-youtube embed/draw:
https://www.simshack.net/products/handley-page-hampden-x-plane-1887

@justinribeiro - it seems with the latest Chrome stable the video does not render at all and we just get black. Just tested a native YT IFRAME embed for the same video and all is fine.

@ryanrbftp
Copy link
Author

Was there any update on this?

Another live example:
https://www.simshack.net/products/bae-146-146-professional-aircraft-add-on-msfs-1896

Many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-info Needs additional information to be debugged. possible-crbug Feels like Chrome is mad about something.
Projects
None yet
Development

No branches or pull requests

3 participants