Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex expression is incorrect #5

Closed
jseminck opened this issue Aug 28, 2016 · 3 comments
Closed

Regex expression is incorrect #5

jseminck opened this issue Aug 28, 2016 · 3 comments

Comments

@jseminck
Copy link

I'm no regex expert, so please correct me if I am wrong.

The current regex for me filtered out files names that ended in: myTest.spec.js. It was matching the .s part. I changed the regex to the following to make it work.

if (filename.match(/.*\.\(css\|less|scss|styl\)/)) {
   return '';
}
@justinsisley
Copy link
Owner

Could you submit a PR for this change?

@p-decoraid
Copy link

p-decoraid commented Oct 6, 2016

Confirming the issue - the regexp as found in npm package excludes any files containing a dot followed by c, s, l, e, t, y or l. In particular a file name like "foo.test.js" has a dot followed by t and would be excluded, "foo.spec.js" has a dot followed by s.

00339d7 has the fix, please release a new version to npm.

@justinsisley
Copy link
Owner

Updated version and published to NPM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants