Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSI breaks on any parser error #10

Closed
justint opened this issue Jun 14, 2020 · 0 comments
Closed

PSI breaks on any parser error #10

justint opened this issue Jun 14, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@justint
Copy link
Owner

justint commented Jun 14, 2020

If the plugin's language parser fails at any point while reading a file, the file's PSI structure breaks which stops any dependent integrations (structure view, code folding, etc) from working. Ideally, the language definition should be as good as possible to avoid this, but I imagine I'll be continually tinkering on the language definition forever, especially if/when language changes come in the future.

The language definition should be updated to support recovering after any failures. How recovery works is defined in the Grammer-Kit: tutorial, how-to. This would ensure parsing failures would be less likely to cause other integrations to stop working.

@justint justint added the bug Something isn't working label Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant