Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compositeOnly does not respect ignoreTransparency #14

Closed
719media opened this issue Jun 11, 2020 · 5 comments · Fixed by #21
Closed

compositeOnly does not respect ignoreTransparency #14

719media opened this issue Jun 11, 2020 · 5 comments · Fixed by #21
Assignees
Labels
bug Something isn't working

Comments

@719media
Copy link
Contributor

When setting option compositeOnly: true on a div containing an image, the div unexpectedly does a fade out. I understood this setting to only have an effect on performance, and removing border-radius transitions. I'll try to come up with a reproduction.

@719media
Copy link
Contributor Author

719media commented Jun 11, 2020

See
https://codesandbox.io/s/v-shared-element-compositeonly-ux69q
(Using v-shared-element v2.1.0)
If you remove compositeOnly setting, then fade will no longer happen, as desired.

@justintaddei
Copy link
Owner

The fade is something that I expect to happen. What I wasn't expecting is that it "pops" to the new shape.

Is should look like the gif in the docs:

The reason for the fade was to "blend" them better during the transition (basically just a cross fade). If there's a behavior you think would be better, I'm open to changing it.

I'm currently out of town and away from my computer so I can't experiment for a day or two

@719media
Copy link
Contributor Author

I was under the impression that using ignoreTransparency: true would make the transparency fade not happen.

@justintaddei
Copy link
Owner

justintaddei commented Jun 12, 2020

Ah yes. I see your point. ignoreTransparency should definitely override the fade introduced by compositeOnly. That comes from illusory so I'll have to change the behavior there first.

I should be back in town by June 13th (provided everything goes alright on the road) so I'll push an update then and report back.

@justintaddei justintaddei self-assigned this Jun 13, 2020
@justintaddei justintaddei added the bug Something isn't working label Jun 13, 2020
@justintaddei justintaddei modified the milestone: v2.2.0 Jun 13, 2020
@justintaddei justintaddei changed the title compositeOnly produce unexpected fade compositeOnly does not respect ignoreTransparency Jun 13, 2020
@justintaddei
Copy link
Owner

justintaddei commented Jun 13, 2020

This is now fixed in illusory and will propagate here after the release of illusory@1.5.0

Regarding the "pop"

The fade is something that I expect to happen. What I wasn't expecting is that it "pops" to the new shape.

I've identified the cause (justintaddei/illusory#11) so it will be fixed in v1.5.0 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants