Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null safety migration #79

Closed
dna-f opened this issue Mar 4, 2021 · 15 comments
Closed

Null safety migration #79

dna-f opened this issue Mar 4, 2021 · 15 comments
Assignees

Comments

@dna-f
Copy link

dna-f commented Mar 4, 2021

Hi, is Null safety migration on roadmap?

Thanks
Andrea

@justkawal
Copy link
Owner

@dna-f
Alright, I'll start working on the null-safety for excel from this weekend.
It might take a week to move full functional code to null-safety.

Thanks for reminder.
~ Best
~ Kawaljeet Singh
~ Long Live 🔥pen Source

@justkawal justkawal added this to the Migration to null-safety milestone Mar 7, 2021
@justkawal justkawal self-assigned this Mar 8, 2021
@nipunasudha
Copy link

@dna-f
Alright, I'll start working on the null-safety for excel from this weekend.
It might take a week to move full functional code to null-safety.

Thanks for reminder.
~ Best
~ Kawaljeet Singh
~ Long Live pen Source

Thank you! We appreciate your hard work!

@definev
Copy link

definev commented Mar 15, 2021

Hopefully the null-safety excel package is coming soon, my project just depends on this package for completely null-safety
migration!

@vandir
Copy link

vandir commented Mar 16, 2021

Hopefully the null-safety excel package is coming soon, my project just depends on this package for completely null-safety
migration!

Me too!

@AYJF
Copy link

AYJF commented Mar 25, 2021

@dna-f
Alright, I'll start working on the null-safety for excel from this weekend.
It might take a week to move full functional code to null-safety.

Thanks for reminder.
~ Best
~ Kawaljeet Singh
~ Long Live pen Source

Thank you a lot !!!

@justkawal
Copy link
Owner

@dna-f @definev @vandir @AYJF @nipunasudha
Hey there,

The migration is completed but the code is little buggy, It will be released by the end of this month if everything goes good.

@nipunasudha
Copy link

@dna-f @definev @vandir @AYJF @nipunasudha
Hey there,

The migration is completed but the code is little buggy, It will be released by the end of this month if everything goes good.

This is such great news! thank you very much

@AYJF
Copy link

AYJF commented Mar 25, 2021

@dna-f @definev @vandir @AYJF @nipunasudha
Hey there,

The migration is completed but the code is little buggy, It will be released by the end of this month if everything goes good.

thanks you so much !!!!!

@vandir
Copy link

vandir commented Mar 25, 2021

Thank you so much! I'm already testing the null-safety (only to read) and it works well!

@nipunasudha
Copy link

nipunasudha commented Mar 26, 2021

@dna-f @definev @vandir @AYJF @nipunasudha
Hey there,

The migration is completed but the code is little buggy, It will be released by the end of this month if everything goes good.

Flutter recommends publishing a 'nullsafety' version (2.0.0-nullsafe may be?) to the pub.dev as soon as the migration is complete and then fix the small issues. Just fyi.

@justkawal
Copy link
Owner

@dna-f @definev @vandir @AYJF @nipunasudha
Hey there,
The migration is completed but the code is little buggy, It will be released by the end of this month if everything goes good.

Flutter recommends publishing a 'nullsafety' version (2.0.0-nullsafe may be?) to the pub.dev as soon as the migration is complete and then fix the small issues. Just fyi.

@nipunasudha
Yeah that's true.

So, Code migration was completed but the buggy code was making excel file corrupted as per latest Microsoft Excel.
The null-safety branch's code was not good as most of the edit was suggested by dart's migration tool.

After that, made new branch (experiment)[https://github.com/justkawal/excel/tree/experiment] 2 days ago and then made the migration starting from scratch without using dart-migration tool.

By EOD, null-safe version will be available on https://pub.dev/packages/excel

Post the issues, if encountered any !!

~ Best
~ Kawal
~ Long Live 🔥pen Source

@nipunasudha
Copy link

Screenshot_20210329-140204

It seems like update is not available yet. We are patiently waiting for the Flutter 2.0 null safety goodness 😁🤩

@justkawal
Copy link
Owner

justkawal commented Mar 29, 2021

Truly Sorry for delay,

My Mac (2015) was causing problems and was not turning on, So it turned on an hour ago by luck.

About to publish the null-safe version on https://pub.dev/packages/excel

🥳 All can have save() function for flutter web and dart client available.

Stay tuned!! Thanks for having patience. 💯

Again Truly Sorry for delays!!

@nipunasudha
Copy link

No apologies necessary. We are grateful for your time & effort!
The release just became available. Thank you very much!

@TTigre
Copy link

TTigre commented Feb 8, 2022

When is a stable null safe version expected to be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants