Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings during install #119

Open
challet opened this issue Apr 24, 2019 · 1 comment
Open

Deprecation warnings during install #119

challet opened this issue Apr 24, 2019 · 1 comment

Comments

@challet
Copy link

challet commented Apr 24, 2019

Hello, some of this warnings are outputed during the install process. They seem to be related to nan functions.

$ npm install bignum

> bignum@0.13.0 install /Users/challet/node_modules/bignum
> prebuild-install || node-gyp rebuild

prebuild-install WARN install No prebuilt binaries found (target=11.14.0 runtime=node arch=x64 platform=darwin)
  CXX(target) Release/obj.target/bignum/bignum.o
In file included from ../bignum.cc:8:
In file included from ../../nan/nan.h:203:
In file included from ../../nan/nan_new.h:189:
../../nan/nan_implementation_12_inl.h:337:28: warning: 'New' is deprecated: Use Isolate* version [-Wdeprecated-declarations]
  return v8::StringObject::New(value).As<v8::StringObject>();
                           ^
/Users/challet/.node-gyp/11.14.0/include/node/v8.h:5242:37: note: 'New' has been explicitly marked deprecated here
                static Local<Value> New(Local<String> value));
                                    ^
In file included from ../bignum.cc:8:
../../nan/nan.h:1034:44: warning: 'ToString' is deprecated: Use maybe version [-Wdeprecated-declarations]
      v8::Local<v8::String> string = from->ToString();
                                           ^
[ ... ]

30 warnings generated.
  SOLINK_MODULE(target) Release/bignum.node

+ bignum@0.13.0

$ node -v
v11.14.0
@tjtarunkumar
Copy link

yes ihave the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants