Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.toString(36) not supported #19

Closed
Meekohi opened this issue Jul 22, 2013 · 8 comments
Closed

.toString(36) not supported #19

Meekohi opened this issue Jul 22, 2013 · 8 comments

Comments

@Meekohi
Copy link

Meekohi commented Jul 22, 2013

Only base 10 and 16 are supported. Would like to see base 36 support (popular for generating human-readable keys from large numbers).

@gjohnson
Copy link

gjohnson commented May 8, 2014

+1

@rvagg
Copy link
Collaborator

rvagg commented May 8, 2014

feel free to submit a pull request for this

@gjohnson
Copy link

gjohnson commented May 8, 2014

@rvagg I would love to try and do this. If you could perhaps point me in the slightest direction since I have no idea what I am doing with C++, it would be greatly appreciated!

Would this implementation be a horrible one to use as a guide (despite being in Objective-C)?

@rvagg
Copy link
Collaborator

rvagg commented May 8, 2014

that's probably not the worst you could follow, just implement a good set of test cases for this and then start stabbing away at C++ until you get stuff to pass, then others can contribute to prettifying or correctifying your C++.

@Meekohi
Copy link
Author

Meekohi commented Oct 16, 2014

I guess I will bump this to remind myself to contibute to this. node-bigint is so unreliable during installation that I once again tried node-bignum, forgetting it doesn't support base36 which I need :)

@gjohnson
Copy link

Go for it @Meekohi, I ended up not needing base 36 after all.

@rvagg
Copy link
Collaborator

rvagg commented Feb 18, 2015

will wait for a PR for this

@Meekohi
Copy link
Author

Meekohi commented Sep 22, 2015

Thanks @cbarton! Embarrassed I never took the time to tackle this myself... ;) Maybe I'll try the other direction at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants