Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.eslintrc has invalid duplicate setting from npm #43

Closed
jprianos-accusoft opened this issue Sep 6, 2016 · 3 comments
Closed

.eslintrc has invalid duplicate setting from npm #43

jprianos-accusoft opened this issue Sep 6, 2016 · 3 comments

Comments

@jprianos-accusoft
Copy link

The .eslintrc file in the npm package is invalid, causing linting checks to fail.

Steps to reproduce:

$ eslint index.js
YAMLException: Cannot read config file: /path/to/node_modules/extend/.eslintrc
Error: duplicated mapping key at line 45, column 30:
"beforeLineComment": false,

Related part of .eslintrc:

  "lines-around-comment": [2, {
        "beforeBlockComment": false,
        "afterBlockComment": false,
        "beforeLineComment": false,
        "beforeLineComment": false,
        "allowBlockStart": true,
        "allowBlockEnd": true
    }],
@ljharb
Copy link
Collaborator

ljharb commented Sep 6, 2016

Thanks, I'll fix that. I'm confused how eslint is running into it though; it should not be linting inside node_modules.

@jprianos-accusoft
Copy link
Author

jprianos-accusoft commented Sep 6, 2016

It was a configuration issue on our gulp tasks, which has been fixed. I just figured I'd point it out to have the root issue corrected as well.

@ljharb
Copy link
Collaborator

ljharb commented Sep 6, 2016

This has been fixed in 8ffd263.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants