-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image IDs differ when using --tree vs --dot #24
Comments
Thanks for catching that, will do a release soon. |
Great, thanks for the quick resolution! |
Just tested this, and it's better. But the IDs provided via the --tree option still have a "sha256:" prefix. Do you think you could remove this? Again, ideally this ID should match the output from "docker images", which is the ID that we need to use with other docker commands (e.g. docker rmi ). |
Good point, just added a commit to do that. I tried to match up with Incidentally, you can pass in the image names with the |
This is a part of the latest release, v0.4.2. Thanks. |
I wasn't sure if the prefix was allowed in other docker commands, but it's definitely nicer if the outputs match. Thank you, again! |
When running using --tree the ID is "missing" for images without a hash, and "sha1:hash" for images with a hash. When running using --dot all images contain the "synth:fake" value.
I think it would be best if both --tree and --dot produced the same output. Moreover, this output should match the output from docker images when possible. In other words, whenever a hash is available, it should be without a prefix and it should use the first 12 characters of the sha hash (unless the -n option is used). When a hash is not available, both should provide the same (either "missing", or better yet, the "synth:fake" value).
The text was updated successfully, but these errors were encountered: