Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image IDs differ when using --tree vs --dot #24

Closed
kevin-canadian opened this issue Jun 2, 2016 · 6 comments
Closed

Image IDs differ when using --tree vs --dot #24

kevin-canadian opened this issue Jun 2, 2016 · 6 comments

Comments

@kevin-canadian
Copy link

kevin-canadian commented Jun 2, 2016

When running using --tree the ID is "missing" for images without a hash, and "sha1:hash" for images with a hash. When running using --dot all images contain the "synth:fake" value.

I think it would be best if both --tree and --dot produced the same output. Moreover, this output should match the output from docker images when possible. In other words, whenever a hash is available, it should be without a prefix and it should use the first 12 characters of the sha hash (unless the -n option is used). When a hash is not available, both should provide the same (either "missing", or better yet, the "synth:fake" value).

@justone
Copy link
Owner

justone commented Jun 11, 2016

Thanks for catching that, will do a release soon.

@kevin-canadian
Copy link
Author

Great, thanks for the quick resolution!

@kevin-canadian
Copy link
Author

Just tested this, and it's better. But the IDs provided via the --tree option still have a "sha256:" prefix. Do you think you could remove this? Again, ideally this ID should match the output from "docker images", which is the ID that we need to use with other docker commands (e.g. docker rmi ).

@justone
Copy link
Owner

justone commented Jun 14, 2016

Good point, just added a commit to do that. I tried to match up with docker images way of doing things.

Incidentally, you can pass in the image names with the sha256: prefix and docker images will do the right thing.

@justone
Copy link
Owner

justone commented Jun 14, 2016

This is a part of the latest release, v0.4.2.

Thanks.

@kevin-canadian
Copy link
Author

I wasn't sure if the prefix was allowed in other docker commands, but it's definitely nicer if the outputs match. Thank you, again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants